Skip to content

6326 clone with keyword args #6329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 2 commits into from
Apr 11, 2023
Merged

6326 clone with keyword args #6329

wyli merged 2 commits into from
Apr 11, 2023

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Apr 11, 2023

Fixes #6326

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
fixes Project-MONAI#6326
a3aaaab 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from KumoLiu and Nic-Ma April 11, 2023 07:02
Nic-Ma
Nic-Ma approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KumoLiu Could you please help double confirm it?

Thanks in advance.

@wyli
update based on comments
83eae90 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
KumoLiu
KumoLiu approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wyli wyli changed the base branch from dev to auto-update April 11, 2023 07:54
@wyli wyli merged commit 2b6d0de into Project-MONAI:auto-update Apr 11, 2023
@wyli wyli deleted the 6326-clone-param branch April 11, 2023 07:54
@wyli wyli mentioned this pull request Apr 11, 2023
Merged
wyli added a commit that referenced this pull request Apr 11, 2023
@monai-bot @mingxin-zheng
@liamchalcroft @wyli @KumoLiu
auto updates (#6324)
9ef42ff 
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

(closing #6318 closing #6319 auto3dseg)
(closing #6314 closing #6315 dtype conversion)
(closing #6326 closing #6329 metatensor clone)
(including a workaround for #6311)

---------

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Liam Chalcroft <liam.chalcroft.20@ucl.ac.uk>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Co-authored-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Co-authored-by: Liam Chalcroft <liam.chalcroft.20@ucl.ac.uk>
Co-authored-by: Wenqi Li <wenqil@nvidia.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Co-authored-by: Wenqi Li <831580+wyli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@KumoLiu KumoLiu KumoLiu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MetaTensor conflict with Tensorboard

3 participants

@wyli @Nic-Ma @KumoLiu