Skip to content

Fix sliding_window_inference #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 9 commits into from
Apr 11, 2023
Merged

Fix sliding_window_inference #6325

wyli merged 9 commits into from
Apr 11, 2023

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Apr 10, 2023

Fixes #6320 .

Description

Ensure sliding_window_inference can support output in dict and tuple format.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

KumoLiu added 2 commits April 10, 2023 16:14
@KumoLiu
fix Project-MONAI#6320
a958190 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
Merge branch 'dev' of https://github.com/Project-MONAI/MONAI into fix…
dd92ba1 
…-sliding-window-inference
@KumoLiu KumoLiu requested review from Nic-Ma and wyli April 10, 2023 08:17
@KumoLiu
fix flake8
c873507 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu mentioned this pull request Apr 11, 2023
Merged
10 tasks
yiheng-wang-nv
yiheng-wang-nv reviewed Apr 11, 2023
View reviewed changes
yiheng-wang-nv
yiheng-wang-nv reviewed Apr 11, 2023
View reviewed changes
KumoLiu added 5 commits April 11, 2023 14:40
@KumoLiu
address comments
d24652e 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
update type hints
41b3a49 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
fix flake8
bb4d3b2 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
use convert_to_dst_type instead
16fcbbc 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
minor fix
04da439 
Signed-off-by: KumoLiu <yunl@nvidia.com>
Nic-Ma
Nic-Ma reviewed Apr 11, 2023
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wyli Could you please help review this PR as you just refactored SlidingWindow?

Thanks in advance.

wyli
wyli approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, I'll also verify the speed and merge this

@wyli wyli changed the base branch from dev to auto-update April 11, 2023 07:52
@wyli
Merge branch 'auto-update' into fix-sliding-window-inference
02ab606 
Signed-off-by: Wenqi Li <831580+wyli@users.noreply.github.com>
@wyli wyli merged commit 0a4898a into Project-MONAI:auto-update Apr 11, 2023
@KumoLiu KumoLiu deleted the fix-sliding-window-inference branch April 11, 2023 08:14
@wyli wyli mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Nic-Ma left review comments

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sliding_window_inference cannot handle output in formats other than tensor

4 participants

@KumoLiu @wyli @Nic-Ma @yiheng-wang-nv