Skip to content

Added Geometric Transforms #7386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
vikashg wants to merge 15 commits into
base: dev
Choose a base branch
from
Draft

Added Geometric Transforms #7386

vikashg wants to merge 15 commits into from

Conversation

@vikashg
Copy link

@vikashg vikashg commented Jan 12, 2024

Fixes # .

Description

This pull request produces few Geometric transforms implementation along with some example code.
The added transforms are

  • LoadImageAndAnnotations
  • FlipImageAndAnnotations
  • RotateImageAndAnnotations
  • ResampleImageAndAnnotations

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Vikash Gupta and others added 2 commits January 12, 2024 14:57
Added Geometric Transforms
e35320d 
Signed-off-by: Vikash Gupta <gupta.vikash@mayo.edu>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d15f1fb 
for more information, see https://pre-commit.ci
Nic-Ma
Nic-Ma reviewed Jan 17, 2024
View reviewed changes
monai/apps/detection/transforms/GeometricTransforms.py
return img


class ImageIntensityAndAnnotation:
Copy link
Contributor

@Nic-Ma Nic-Ma Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all the MONAI transforms should inherit and follow the base signature, @ericspod @atbenmurray what do you think?

Thanks.

Copy link
Member

@ericspod ericspod Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should in general, yes, but this is a prototype for discussion so I don't think it's a problem. Maybe the PR should be draft so it's clear we aren't proposing things as-is.

ericspod
ericspod reviewed Jan 17, 2024
View reviewed changes
monai/apps/detection/transforms/sample_data/Mammo_194_LMLO_N_080839.json Outdated
Copy link
Member

@ericspod ericspod Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that Github doesn't appear to like the huge base64 blob that's in this file. It's one long line that's making it impossible to view the file or its delta.

Copy link
Author

@vikashg vikashg Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I will try to upload another json file. But I dont think you need to view the json file as it contains that blob which is a result from labelme. I just dont use that part. I can remove it and reupload the file tomorrow.

@KumoLiu KumoLiu marked this pull request as draft January 18, 2024 02:14
@atbenmurray atbenmurray mentioned this pull request Jan 19, 2024
Closed
7 tasks
@vikashg vikashg linked an issue Jan 20, 2024 that may be closed by this pull request
Applying Transform Chain to Geometric Objects #4027
Open
Vikash Gupta and others added 9 commits January 21, 2024 00:03
Made small corrections
04161de 
Signed-off-by: Vikash Gupta <gupta.vikash@mayo.edu>
Removed python notebook
80b2df7 
Signed-off-by: Vikash Gupta <gupta.vikash@mayo.edu>
Removed old files
45db14f 
Signed-off-by: Vikash Gupta <gupta.vikash@mayo.edu>
Modified demo
4a0c1d7 
Signed-off-by: Vikash Gupta <gupta.vikash@mayo.edu>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
51fec4a 
for more information, see https://pre-commit.ci
@vikashg
Adding a design description for Geometric Transforms
a097c4a 
Signed-off-by: Vikash Gupta <write2vikash@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
bddf714 
for more information, see https://pre-commit.ci
@vikashg
Update DesignGeometricTransforms.md
e4ec94c 
Added my thoughts after the 2/7 meeting. 

Signed-off-by: Vikash Gupta <write2vikash@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d2211a7 
for more information, see https://pre-commit.ci
@KumoLiu KumoLiu added this to the Geometric Transform API milestone Mar 1, 2024
KumoLiu and others added 4 commits April 12, 2024 14:37
@KumoLiu
Add kind property in MetaTensor (Project-MONAI#7488)
00436d0 
Part of Project-MONAI#7486


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@vikashg
Merge branch 'Project-MONAI:geometric' into geometric
70007f7
@KumoLiu @monai-bot
@bakert1 @MathijsdeBoer @dependabot @ericspod @SomeUserName1 @yiheng-wang-nv @Lucas-rbnt @pre-commit-ci @cxlcl @juampatronics @elitap @f-schnabel @YanxuanLiu @ytl0623 @dzenanz @ishandutta0098 @kvttt @heyufan1995 @binliunls @atbenmurray @vlaminckaxel @mingxin-zheng @ibro45 @bhashemian @johnzielke @scalyvladimir @lorinczszabolcs @Nic-Ma @freddiewanah @k-sukharev @MattTheCuber @Pkaps25 @simojens @NabJa @Yu0610 @alkamid @MrGranddy @kephale @guopengf @dongyang0122 @Can-Zhao @hjmjohnson @marksgraham @vgrau98 @wyli @myron @virginiafdez
Merge dev into geometric (Project-MONAI#7931)
6687962 
Fixes # .

### Description

A few sentences describing the changes proposed in this pull request.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Timothy Baker <bakertim@umich.edu>
Signed-off-by: Mathijs de Boer <m.deboer-41@umcutrecht.nl>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Fabian Klopfer <fabian.klopfer@ieee.org>
Signed-off-by: Lucas Robinet <robinet.lucas@iuct-oncopole.fr>
Signed-off-by: Lucas Robinet <67736918+Lucas-rbnt@users.noreply.github.com>
Signed-off-by: chaoliu <chaoliu@nvidia.com>
Signed-off-by: cxlcl <chaoliucxl@gmail.com>
Signed-off-by: chaoliu <chaoliucxl@gmail.com>
Signed-off-by: Suraj Pai <b.pai@maastrichtuniversity.nl>
Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Signed-off-by: elitap <elias.tappeiner@gmx.at>
Signed-off-by: Felix Schnabel <f.schnabel@tum.de>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: ytl0623 <david89062388@gmail.com>
Signed-off-by: Dženan Zukić <dzenan.zukic@kitware.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: Ishan Dutta <ishandutta0098@gmail.com>
Signed-off-by: kaibo <ktang@unc.edu>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: axel.vlaminck <axel.vlaminck@gmail.com>
Signed-off-by: Ibrahim Hadzic <ibrahimhadzic45@gmail.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: John Zielke <j.l.zielke@gmail.com>
Signed-off-by: Mingxin Zheng <mingxinz@nvidia.com>
Signed-off-by: Vladimir Chernyi <57420464+scalyvladimir@users.noreply.github.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Szabolcs Botond Lorincz Molnar <szabolcs.lorincz@mvision.ai>
Signed-off-by: Lucas Robinet <luca.robinet@gmail.com>
Signed-off-by: Mingxin <mingxinz@nvidia.com>
Signed-off-by: Han Wang <freddie.wanah@gmail.com>
Signed-off-by: Konstantin Sukharev <k.sukharev@gmail.com>
Signed-off-by: Ben Murray <ben.murray@gmail.com>
Signed-off-by: Matthew Vine <32849887+MattTheCuber@users.noreply.github.com>
Signed-off-by: Peter Kaplinsky <peterkaplinsky@gmail.com>
Signed-off-by: Simon Jensen <61684806+simojens@users.noreply.github.com>
Signed-off-by: NabJa <nabil.jabareen@gmail.com>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: alkamid <adam.klimont@cydar.co.uk>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: MrGranddy <bugrayesilkaynak@gmail.com>
Signed-off-by: Vahit Buğra YEŞİLKAYNAK <bugrayesilkaynak@gmail.com>
Signed-off-by: Kyle Harrington <czi@kyleharrington.com>
Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
Signed-off-by: Pengfei Guo <32000655+guopengf@users.noreply.github.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: Dong Yang <yangd05@Dongs-MacBook-Pro.local>
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <69829124+Can-Zhao@users.noreply.github.com>
Signed-off-by: Hans Johnson <hans-johnson@uiowa.edu>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <mark@Marks-MacBook-Pro.local>
Signed-off-by: vgrau98 <victor.grau93@gmail.com>
Signed-off-by: vgrau98 <35843843+vgrau98@users.noreply.github.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: dongy <dongy@nvidia.com>
Signed-off-by: myron <amyronenko@nvidia.com>
Signed-off-by: virginiafdez <virginia.fernandez@kcl.ac.uk>
Co-authored-by: monai-bot <64792179+monai-bot@users.noreply.github.com>
Co-authored-by: Timothy J. Baker <62781117+tim-the-baker@users.noreply.github.com>
Co-authored-by: Mathijs de Boer <8137653+MathijsdeBoer@users.noreply.github.com>
Co-authored-by: Mathijs de Boer <m.deboer-41@umcutrecht.nl>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Co-authored-by: Fabian Klopfer <fabian.klopfer@ieee.org>
Co-authored-by: Yiheng Wang <68361391+yiheng-wang-nv@users.noreply.github.com>
Co-authored-by: Lucas Robinet <67736918+Lucas-rbnt@users.noreply.github.com>
Co-authored-by: Lucas Robinet <robinet.lucas@iuct-oncopole.fr>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: cxlcl <chaoliucxl@gmail.com>
Co-authored-by: Suraj Pai <b.pai@maastrichtuniversity.nl>
Co-authored-by: Juampa <1523654+juampatronics@users.noreply.github.com>
Co-authored-by: elitap <elitap@users.noreply.github.com>
Co-authored-by: Felix Schnabel <f.schnabel@tum.de>
Co-authored-by: YanxuanLiu <104543031+YanxuanLiu@users.noreply.github.com>
Co-authored-by: ytl0623 <david89062388@gmail.com>
Co-authored-by: Dženan Zukić <dzenan.zukic@kitware.com>
Co-authored-by: Ishan Dutta <ishandutta0098@gmail.com>
Co-authored-by: Kaibo Tang <ktang@unc.edu>
Co-authored-by: Yufan He <59374597+heyufan1995@users.noreply.github.com>
Co-authored-by: binliunls <107988372+binliunls@users.noreply.github.com>
Co-authored-by: Ben Murray <ben.murray@gmail.com>
Co-authored-by: axel.vlaminck <axel.vlaminck@gmail.com>
Co-authored-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Co-authored-by: Ibrahim Hadzic <ibrahimhadzic45@gmail.com>
Co-authored-by: Dr. Behrooz Hashemian <3968947+drbeh@users.noreply.github.com>
Co-authored-by: johnzielke <j.l.zielke@gmail.com>
Co-authored-by: Vladimir Chernyi <57420464+scalyvladimir@users.noreply.github.com>
Co-authored-by: Lőrincz-Molnár Szabolcs-Botond <lorincz_szabolcs@yahoo.com>
Co-authored-by: Nic Ma <nma@nvidia.com>
Co-authored-by: Lucas Robinet <luca.robinet@gmail.com>
Co-authored-by: Han Wang <freddie.wanah@gmail.com>
Co-authored-by: Konstantin Sukharev <50718389+k-sukharev@users.noreply.github.com>
Co-authored-by: Matthew Vine <32849887+MattTheCuber@users.noreply.github.com>
Co-authored-by: Pkaps25 <43655728+Pkaps25@users.noreply.github.com>
Co-authored-by: Peter Kaplinsky <peterkaplinsky@gmail.com>
Co-authored-by: Simon Jensen <61684806+simojens@users.noreply.github.com>
Co-authored-by: NabJa <32510324+NabJa@users.noreply.github.com>
Co-authored-by: Yu <146002968+Yu0610@users.noreply.github.com>
Co-authored-by: Adam Klimont <adamkli@gmail.com>
Co-authored-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Co-authored-by: Vahit Buğra YEŞİLKAYNAK <bugrayesilkaynak@gmail.com>
Co-authored-by: ge85evz <vanessa_share@nevarro.ifl.campar.in.tum.de>
Co-authored-by: Kyle I S Harrington <kephale@users.noreply.github.com>
Co-authored-by: Pengfei Guo <32000655+guopengf@users.noreply.github.com>
Co-authored-by: Dong Yang <don.yang.mech@gmail.com>
Co-authored-by: Dong Yang <yangd05@Dongs-MacBook-Pro.local>
Co-authored-by: Can Zhao <69829124+Can-Zhao@users.noreply.github.com>
Co-authored-by: Hans Johnson <hans-johnson@uiowa.edu>
Co-authored-by: Mark Graham <markgraham539@gmail.com>
Co-authored-by: vgrau98 <35843843+vgrau98@users.noreply.github.com>
Co-authored-by: Wenqi Li <831580+wyli@users.noreply.github.com>
Co-authored-by: myron <myron@users.noreply.github.com>
Co-authored-by: Kaibo Tang <99367900+kvttt@users.noreply.github.com>
Co-authored-by: Virginia Fernandez <61539159+virginiafdez@users.noreply.github.com>
Co-authored-by: virginiafdez <virginia.fernandez@kcl.ac.uk>
@vikashg
Merge branch 'Project-MONAI:geometric' into geometric
6e7744e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericspod ericspod ericspod left review comments

@Nic-Ma Nic-Ma Nic-Ma left review comments

@virginiafdez virginiafdez Awaiting requested review from virginiafdez virginiafdez will be requested when the pull request is marked ready for review virginiafdez is a code owner

@KumoLiu KumoLiu Awaiting requested review from KumoLiu KumoLiu will be requested when the pull request is marked ready for review KumoLiu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Geometric Transforms
Status: No status

Milestone

Geometric Transform API [P0 v1.4]

Development

Successfully merging this pull request may close these issues.

Applying Transform Chain to Geometric Objects

4 participants

@vikashg @ericspod @Nic-Ma @KumoLiu