Fix test error in test_soft_clipping_one_sided_high
#7624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Contributor
Author
|
/build |
for more information, see https://pre-commit.ci
Contributor
Author
|
cc @Lucas-rbnt, could you please help review this one? Thanks. |
mingxin-zheng
approved these changes
Apr 11, 2024
Contributor
mingxin-zheng
left a comment
mingxin-zheng
left a comment
There was a problem hiding this comment.
It seems good to me that we unify the backend of percentile computation in the tests.
Contributor
Author
|
/build |
Nic-Ma
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7616
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.