Skip to content

feat: #228 popover attribute typings#229

Merged
thescientist13 merged 1 commit intomasterfrom
feat/issue-228-popover-target-typescript-support
Feb 5, 2026
Merged

feat: #228 popover attribute typings#229
thescientist13 merged 1 commit intomasterfrom
feat/issue-228-popover-target-typescript-support

Conversation

@thescientist13
Copy link
Copy Markdown
Member

@thescientist13 thescientist13 commented Jan 29, 2026

Related Issue

resolves #228

Summary of Changes

  1. Add custom typings for popovertarget and popovertargetaction
  2. Add DOM lib recommendation to TSX setup

TODO

  1. Should we refine this to just button and input, per Move popovertarget and popovertargetaction data from global_attibutes to <button> and <input> mdn/browser-compat-data#21875 ? - narrow popover related attribute types to just <button> and <input> elements #236
  2. Do we even need the override at all? - narrow popover related attribute types to just <button> and <input> elements #236

@thescientist13 thescientist13 added documentation Improvements or additions to the website and / or documentation help wanted Extra attention is needed question Further information is requested enhancement Improvement to existing functionality types labels Jan 29, 2026
@thescientist13 thescientist13 force-pushed the feat/issue-228-popover-target-typescript-support branch from 51ab8a4 to e83b5ad Compare February 5, 2026 03:14
@thescientist13 thescientist13 merged commit 0ec9f82 into master Feb 5, 2026
12 checks passed
@thescientist13 thescientist13 deleted the feat/issue-228-popover-target-typescript-support branch February 5, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to the website and / or documentation enhancement Improvement to existing functionality help wanted Extra attention is needed question Further information is requested types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

popover target related attributes are not being recognized by TypeScript

1 participant