Skip to content

Move popovertarget and popovertargetaction data from global_attibutes to <button> and <input>#21875

Merged
Elchi3 merged 1 commit intomdn:mainfrom
skyclouds2001:popovertarget&popovertargetaction
Jan 24, 2024
Merged

Move popovertarget and popovertargetaction data from global_attibutes to <button> and <input>#21875
Elchi3 merged 1 commit intomdn:mainfrom
skyclouds2001:popovertarget&popovertargetaction

Conversation

@skyclouds2001
Copy link
Copy Markdown
Contributor

Summary

the popovertarget and popovertargetaction attribute can only used for <button> and <input> of some types

in popver spec says:

Buttons may have the following content attributes:

  • popovertarget

  • popovertargetaction

also, the two properties are listed in the

popover spec https://html.spec.whatwg.org/multipage/popover.html#the-popover-target-attributes
button spec https://html.spec.whatwg.org/multipage/form-elements.html#the-button-element
input spec https://html.spec.whatwg.org/multipage/input.html#the-input-element

also, I check mdn content and confirm it does not need to update

Test results and supporting details

Related issues

Fixes #21792

@github-actions github-actions Bot added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Jan 9, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 9, 2024 06:57
@skyclouds2001 skyclouds2001 changed the title move popovertarget and popovertargetaction data from global_attibutes to button and input Move popovertarget and popovertargetaction data from global_attibutes to button and input Jan 10, 2024
@skyclouds2001 skyclouds2001 changed the title Move popovertarget and popovertargetaction data from global_attibutes to button and input Move popovertarget and popovertargetaction data from global_attibutes to <button> and <input> Jan 10, 2024
Copy link
Copy Markdown
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Well spotted! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML

Projects

None yet

Development

Successfully merging this pull request may close these issues.

html.global_attributes.popover - popovertarget and popovertargetaction should not regard as html global attribute

2 participants