Skip to content

bug: remove patch-package postinstall script breaking npm installs#261

Merged
thescientist13 merged 2 commits intomasterfrom
bug/remove-patch-package-post-install
Apr 16, 2026
Merged

bug: remove patch-package postinstall script breaking npm installs#261
thescientist13 merged 2 commits intomasterfrom
bug/remove-patch-package-post-install

Conversation

@thescientist13
Copy link
Copy Markdown
Member

@thescientist13 thescientist13 commented Apr 16, 2026

Related Issue

#233

Summary of Changes

  1. Remove patch-package postinstall script that was breaking npm installs in feature(plugins): support wcc signals in import jsx plugin greenwood#1667
  2. Document manual running of patch-package in CONTRIBUTING.md

The failure is due to WCC having a postinstall script to run patch-package but as it is only a dev dep, it won't be found and will fail. (and honestly, we really shouldn't be shipping with a postinstall script)

Screenshot 2026-04-15 at 10 49 05 PM
warning Workspaces can only be enabled in private projects.
[4/4] Building fresh packages...
error /home/runner/work/greenwood/greenwood/node_modules/wc-compiler: Command failed.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Exit code: 127
Command: patch-package
Arguments: 
Directory: /home/runner/work/greenwood/greenwood/node_modules/wc-compiler
Output:
/bin/sh: 1: patch-package: not found
Error: Process completed with exit code 127.

@thescientist13 thescientist13 added this to the 1.0 milestone Apr 16, 2026
@thescientist13 thescientist13 self-assigned this Apr 16, 2026
@thescientist13 thescientist13 added the bug Something isn't working label Apr 16, 2026
@thescientist13 thescientist13 moved this to 👀 In review in [WCC] General Activities Apr 16, 2026
@thescientist13 thescientist13 linked an issue Apr 16, 2026 that may be closed by this pull request
@thescientist13 thescientist13 merged commit a47d297 into master Apr 16, 2026
17 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in [WCC] General Activities Apr 16, 2026
@thescientist13 thescientist13 deleted the bug/remove-patch-package-post-install branch April 16, 2026 03:05
@thescientist13 thescientist13 linked an issue Apr 16, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.21.1 bug Something isn't working

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

reference local version of WCC when building the docs website Signals Based JSX compilation (prototype)

1 participant