Skip to content

chore: restore netlify builds for patch-package#262

Merged
thescientist13 merged 3 commits intomasterfrom
chore/fix-netlify-patch-package
Apr 16, 2026
Merged

chore: restore netlify builds for patch-package#262
thescientist13 merged 3 commits intomasterfrom
chore/fix-netlify-patch-package

Conversation

@thescientist13
Copy link
Copy Markdown
Member

@thescientist13 thescientist13 commented Apr 16, 2026

Related Issue

Noticed Netlify builds were failing in #252 , was able to confirm locally

➜  wcc git:(chore/fix-netlify-patch-package) ✗ rm -rf node_modules 
➜  wcc git:(chore/fix-netlify-patch-package) ✗ npm ci
....

➜  wcc git:(chore/fix-netlify-patch-package) ✗ npm run build
npm error Missing script: "build"
npm error
npm error To see a list of scripts, run:
npm error   npm run
npm error A complete log of this run can be found in: /Users/owenbuckley/.npm/_logs/2026-04-16T23_25_39_036Z-debug-0.log
➜  wcc git:(chore/fix-netlify-patch-package) ✗ npm run docs:build

> wc-compiler@0.21.1 docs:build
> NODE_OPTIONS='--import @greenwood/cli/register' greenwood build

-------------------------------------------------------
Welcome to Greenwood (v0.34.0-alpha.4) ♻️
-------------------------------------------------------
Running Greenwood with the build command.
Initializing project config
Initializing project workspace contexts
Generating graph of workspace files...
building from local sources...
pages to generate 
 /docs/
 /examples/
 /
 /sandbox/
Initializing active content...
ReferenceError [Error]: Signal is not defined
    at new SignalGreeting (file:///Users/owenbuckley/Workspace/project-evergreen/wcc/docs/components/sandbox/signal-greeting.tsx:39:21)
    at initializeCustomElement (file:///Users/owenbuckley/Workspace/project-evergreen/wcc/node_modules/wc-compiler/src/wcc.js:196:29)
    at async renderComponentRoots (file:///Users/owenbuckley/Workspace/project-evergreen/wcc/node_modules/wc-compiler/src/wcc.js:32:33)
    at async renderComponentRoots (file:///Users/owenbuckley/Workspace/project-evergreen/wcc/node_modules/wc-compiler/src/wcc.js:64:7)
    at async renderComponentRoots (file:///Users/owenbuckley/Workspace/project-evergreen/wcc/node_modules/wc-compiler/src/wcc.js:64:7)
    at async renderComponentRoots (file:///Users/owenbuckley/Workspace/project-evergreen/wcc/node_modules/wc-compiler/src/wcc.js:64:7)
    at async renderFromHTML (file:///Users/owenbuckley/Workspace/project-evergreen/wcc/node_modules/wc-compiler/src/wcc.js:262:21)
    at async executeRouteModule (file:///Users/owenbuckley/Workspace/project-evergreen/wcc/node_modules/@greenwood/cli/src/lib/execute-route-module.js:23:22)
    at async executeModule (file:///Users/owenbuckley/Workspace/project-evergreen/wcc/node_modules/@greenwood/cli/src/lib/ssr-route-worker.js:17:16)
    at async MessagePort.<anonymous> (file:///Users/owenbuckley/Workspace/project-evergreen/wcc/node_modules/@greenwood/cli/src/lib/ssr-route-worker.js:33:3)

Summary of Changes

  1. Include patch-package install for Netlify builds

Not sure why #261 build didn't fail in Netlify, maybe the build was cached? 🤔

@thescientist13 thescientist13 changed the title chore: test commit chore: restore netlify builds for patch-package Apr 16, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 16, 2026

Deploy Preview for merry-caramel-524e61 failed.

Name Link
🔨 Latest commit c6f1fa4
🔍 Latest deploy log https://app.netlify.com/projects/merry-caramel-524e61/deploys/69e17082fc3b2240ad351609

@thescientist13
Copy link
Copy Markdown
Member Author

OK yeah, even though Netlify deploy worked the first time here
Screenshot 2026-04-16 at 7 27 56 PM

after building without cache it failed again
Screenshot 2026-04-16 at 7 31 10 PM

Copy link
Copy Markdown
Member Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, even with a force build and no cache, can confirm it is working now
Image

@thescientist13 thescientist13 marked this pull request as ready for review April 16, 2026 23:35
@thescientist13 thescientist13 linked an issue Apr 16, 2026 that may be closed by this pull request
@thescientist13 thescientist13 moved this to 👀 In review in [WCC] General Activities Apr 16, 2026
@thescientist13 thescientist13 self-assigned this Apr 16, 2026
@thescientist13 thescientist13 merged commit 3c7cd2c into master Apr 16, 2026
17 checks passed
@thescientist13 thescientist13 deleted the chore/fix-netlify-patch-package branch April 16, 2026 23:36
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in [WCC] General Activities Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Signals Based JSX compilation (prototype)

1 participant