Skip to content

fix order null maker error #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tpetrychyn wants to merge 4 commits into from
Closed

fix order null maker error #1838

tpetrychyn wants to merge 4 commits into from

Conversation

@tpetrychyn
Copy link
Contributor

@tpetrychyn tpetrychyn commented Dec 7, 2025 •
edited
Loading

Motivation

/app/node_modules/opensea-js/src/utils/converters.ts:97
    address: account.address,
                     ^

TypeError: Cannot read properties of undefined (reading 'address')
    at accountFromJSON (/app/node_modules/opensea-js/src/utils/converters.ts:97:22)
    at deserializeOrder (/app/node_modules/opensea-js/src/orders/utils.ts:221:27)
    at OrdersAPI.getOrderByHash (/app/node_modules/opensea-js/src/api/orders.ts:84:28)
    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)

Solution

Makes order.maker nullable

@tpetrychyn tpetrychyn closed this Dec 7, 2025
@tpetrychyn tpetrychyn deleted the tpetrychyn/order-null-addr branch December 7, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tpetrychyn