fix order null maker error

src/orders/types.ts

@@ -36,7 +36,7 @@ export type OrderV2 = {
   /** The hash of the order. */
   orderHash: string | null;
   /** The account that created the order. */
-  maker: OpenSeaAccount;
+  maker: OpenSeaAccount | null;
   /** The account that filled the order. */
   taker: OpenSeaAccount | null;
   /** The protocol data for the order. Only 'seaport' is currently supported. */

src/orders/utils.ts

@@ -218,7 +218,7 @@ export const deserializeOrder = (order: SerializedOrderV2): OrderV2 => {
     listingTime: order.listing_time,
     expirationTime: order.expiration_time,
     orderHash: order.order_hash,
-    maker: accountFromJSON(order.maker),
+    maker: order.maker ? accountFromJSON(order.maker) : null,
     taker: order.taker ? accountFromJSON(order.taker) : null,
     protocolData: order.protocol_data,
     protocolAddress: order.protocol_address,

src/sdk/fulfillment.ts

@@ -299,6 +299,9 @@ export class FulfillmentManager {
    * @throws Error if the order's protocol address is not supported by OpenSea. See {@link isValidProtocol}.
    */
   async approveOrder(order: OrderV2, domain?: string) {
+    if (!order.maker) {
+      throw new Error("Order maker is required to approve an order");
+    }
     await this.context.requireAccountIsAvailable(order.maker.address);
     requireValidProtocol(order.protocolAddress);
 

test/integration/bulkOrders.spec.ts

@@ -94,7 +94,7 @@ suite("SDK: bulk order posting", () => {
       }
       expectValidOrder(order);
       expect(order.expirationTime).to.equal(expirationTime);
-      expect(order.maker.address.toLowerCase()).to.equal(
+      expect(order.maker!.address.toLowerCase()).to.equal(
         walletAddress.toLowerCase(),
       );
     });
@@ -273,7 +273,7 @@ suite("SDK: bulk order posting", () => {
       }
       expectValidOrder(order);
       expect(order.expirationTime).to.equal(expirationTime);
-      expect(order.maker.address.toLowerCase()).to.equal(
+      expect(order.maker!.address.toLowerCase()).to.equal(
         walletAddress.toLowerCase(),
       );
       expect(order.side).to.equal("ask");

test/orders/utils.spec.ts

@@ -518,7 +518,7 @@ suite("Orders: utils", () => {
       expect(result.listingTime).to.equal(1704067200);
       expect(result.expirationTime).to.equal(1735689599);
       expect(result.orderHash).to.equal("0xOrderHash");
-      expect(result.maker.address).to.equal("0xMaker");
+      expect(result.maker!.address).to.equal("0xMaker");
       expect(result.taker?.address).to.equal("0xTaker");
       expect(result.protocolAddress).to.equal("0xProtocol");
       expect(result.currentPrice).to.equal(BigInt("1000000000000000000"));