Fix Android crash and safe area insets, update MAUI to 10.0.31#8
Merged
Fix Android crash and safe area insets, update MAUI to 10.0.31#8
Conversation
- Fix TypeInitializerException on Android: convert static readonly path fields to lazy properties, add Android-safe path fallbacks - Fix safe area insets: use SafeAreaEdges="Container" on ContentPage (.NET 10 breaking change where ContentPage defaults to None/edge-to-edge) - Update MAUI packages from $(MauiVersion) to explicit 10.0.31 - Add Android-specific connection defaults (remote persistent server) - Add GetTempPath() fallback in ServerManager for Android
PureWeen
added a commit
that referenced
this pull request
Feb 20, 2026
Concurrency fixes: - Swap _sessions before wiring event handler on reconnect (#2) - Block ALL events from orphaned handlers, not just terminal (#3) - Add lock(_imageQueueLock) to all image queue mutations (#4) including dequeue, reinsert, ClearQueue, rename, close, dispose - Clear IsResumed on error and watchdog paths (#5) - Add RunContinuationsAsynchronously to remaining TCS (#6) Architecture/contract fixes: - Add [JsonIgnore] to ShouldWarnOnStall, LastSimilarity (#7) - Fix ConsecutiveErrors increment-before-check ordering (#8) - Set IsCancelled on all non-success termination paths (#10) including stall, error-stall, max-iteration, OperationCanceled, empty-assignment error stall, and single-agent StopReflectionCycle - Add session dir deletion for ghost evaluator pruning (#12) - Add CompletedAt to StopReflectionCycle (#12 related) Already correct (no changes needed): - #9: CurrentIteration == 1 check was already fixed - #11: Comments already reference string-based stall detection Documentation: - Update stall detection from 'hash match' to 'string equality' - Update error handling to show ConsecutiveErrors (not ConsecutiveStalls) - Add IsCancelled invariant to exit conditions table - Add 5 new invariants: orphan gate, reconnect ordering, image queue locking, IsResumed clearing, TCS creation - Document empty-assignment retry behavior 817/817 tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 7, 2026
PureWeen
added a commit
that referenced
this pull request
Mar 7, 2026
…t groups (#297) ## Problem When sending a message to an orchestrator session from the **mobile app** (via WebSocket bridge), the message went directly to instead of through the multi-agent dispatch pipeline. The orchestrator responded as a normal chat session — no worker dispatch, no task planning, no synthesis. This was the root cause of the PR Review Squad orchestrator not working after the latest deploy. ## Root Cause `WsBridgeServer.HandleClientMessage` called `SendPromptAsync` directly via `Task.Run`, completely bypassing the orchestration routing that exists in `Dashboard.razor`. The bridge had no awareness of orchestrator sessions. **Evidence from diagnostics:** - Successful orchestrator sends: thread=1 (UI thread, via Dashboard.razor → orchestration pipeline) - Failed sends at 02:00/02:04: thread=44/65 (background, from `Task.Run` in WsBridgeServer) - No `[DISPATCH-ROUTE]` or `[DISPATCH]` logs — orchestration pipeline never executed ## Fix 1. **`WsBridgeServer.cs`** — Now calls `GetOrchestratorGroupId()` before sending. If the target session is an orchestrator, routes through `SendToMultiAgentGroupAsync` instead of direct `SendPromptAsync`. 2. **`CopilotService.cs`** (CreateSessionAsync queue drain) — Same pattern for newly created orchestrator sessions. 3. **`RightClickContextMenuTests.cs`** — Fix pre-existing test failure (proximity threshold too tight after new attributes were added to the session-item div). ## Tests - 4 new unit tests in `MultiAgentRegressionTests.cs` (Bug #8 region) - 3 new integration tests in `WsBridgeIntegrationTests.cs` (bridge orchestration routing) - Fix for 1 pre-existing test failure - **All 2066 tests passing** --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
arisng
pushed a commit
to arisng/PolyPilot
that referenced
this pull request
Apr 4, 2026
…t groups (PureWeen#297) ## Problem When sending a message to an orchestrator session from the **mobile app** (via WebSocket bridge), the message went directly to instead of through the multi-agent dispatch pipeline. The orchestrator responded as a normal chat session — no worker dispatch, no task planning, no synthesis. This was the root cause of the PR Review Squad orchestrator not working after the latest deploy. ## Root Cause `WsBridgeServer.HandleClientMessage` called `SendPromptAsync` directly via `Task.Run`, completely bypassing the orchestration routing that exists in `Dashboard.razor`. The bridge had no awareness of orchestrator sessions. **Evidence from diagnostics:** - Successful orchestrator sends: thread=1 (UI thread, via Dashboard.razor → orchestration pipeline) - Failed sends at 02:00/02:04: thread=44/65 (background, from `Task.Run` in WsBridgeServer) - No `[DISPATCH-ROUTE]` or `[DISPATCH]` logs — orchestration pipeline never executed ## Fix 1. **`WsBridgeServer.cs`** — Now calls `GetOrchestratorGroupId()` before sending. If the target session is an orchestrator, routes through `SendToMultiAgentGroupAsync` instead of direct `SendPromptAsync`. 2. **`CopilotService.cs`** (CreateSessionAsync queue drain) — Same pattern for newly created orchestrator sessions. 3. **`RightClickContextMenuTests.cs`** — Fix pre-existing test failure (proximity threshold too tight after new attributes were added to the session-item div). ## Tests - 4 new unit tests in `MultiAgentRegressionTests.cs` (Bug PureWeen#8 region) - 3 new integration tests in `WsBridgeIntegrationTests.cs` (bridge orchestration routing) - Fix for 1 pre-existing test failure - **All 2066 tests passing** --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 5, 2026
…-hunk gaps - #1 (CRITICAL): Snapshot CM instance IDs before clearing dictionaries in OnParametersSet, preventing InvalidOperationException from enumerator invalidation and ensuring all JS instances are properly disposed - #2 (CRITICAL): Add generation counter to InitCodeMirrorForFile; stale completions (from a previous diff) are detected and disposed immediately - #3: Double-init guard — skip InitCodeMirrorForFile if _cmInstances already contains an entry for the fileIdx - #4: DisposeCmInstance replaced with snapshot-then-remove pattern; _pendingEditorInit cleared on Table toggle to prevent stale inits - #5: ReconstructOriginal/Modified now insert blank placeholder lines for inter-hunk gaps to preserve correct line numbering in CM MergeView - #6: Add SRI integrity hash (sha384) to codemirror-bundle.js script tag - #7: Replace O(n²) Files.IndexOf(file) with indexed for loop - #8: All catch blocks now log to Console.Error with [DiffView] prefix - NEW-1: Post-loop Clear() race eliminated — DisposeJsInstancesByIdAsync works on snapshotted arrays, never touches _cmInstances dictionary - Added _disposed guard to DisposeAsync for safe double-dispose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 5, 2026
…-hunk gaps - #1 (CRITICAL): Snapshot CM instance IDs before clearing dictionaries in OnParametersSet, preventing InvalidOperationException from enumerator invalidation and ensuring all JS instances are properly disposed - #2 (CRITICAL): Add generation counter to InitCodeMirrorForFile; stale completions (from a previous diff) are detected and disposed immediately - #3: Double-init guard — skip InitCodeMirrorForFile if _cmInstances already contains an entry for the fileIdx - #4: DisposeCmInstance replaced with snapshot-then-remove pattern; _pendingEditorInit cleared on Table toggle to prevent stale inits - #5: ReconstructOriginal/Modified now insert blank placeholder lines for inter-hunk gaps to preserve correct line numbering in CM MergeView - #6: Add SRI integrity hash (sha384) to codemirror-bundle.js script tag - #7: Replace O(n²) Files.IndexOf(file) with indexed for loop - #8: All catch blocks now log to Console.Error with [DiffView] prefix - NEW-1: Post-loop Clear() race eliminated — DisposeJsInstancesByIdAsync works on snapshotted arrays, never touches _cmInstances dictionary - Added _disposed guard to DisposeAsync for safe double-dispose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 6, 2026
…-hunk gaps - #1 (CRITICAL): Snapshot CM instance IDs before clearing dictionaries in OnParametersSet, preventing InvalidOperationException from enumerator invalidation and ensuring all JS instances are properly disposed - #2 (CRITICAL): Add generation counter to InitCodeMirrorForFile; stale completions (from a previous diff) are detected and disposed immediately - #3: Double-init guard — skip InitCodeMirrorForFile if _cmInstances already contains an entry for the fileIdx - #4: DisposeCmInstance replaced with snapshot-then-remove pattern; _pendingEditorInit cleared on Table toggle to prevent stale inits - #5: ReconstructOriginal/Modified now insert blank placeholder lines for inter-hunk gaps to preserve correct line numbering in CM MergeView - #6: Add SRI integrity hash (sha384) to codemirror-bundle.js script tag - #7: Replace O(n²) Files.IndexOf(file) with indexed for loop - #8: All catch blocks now log to Console.Error with [DiffView] prefix - NEW-1: Post-loop Clear() race eliminated — DisposeJsInstancesByIdAsync works on snapshotted arrays, never touches _cmInstances dictionary - Added _disposed guard to DisposeAsync for safe double-dispose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 6, 2026
…-hunk gaps - #1 (CRITICAL): Snapshot CM instance IDs before clearing dictionaries in OnParametersSet, preventing InvalidOperationException from enumerator invalidation and ensuring all JS instances are properly disposed - #2 (CRITICAL): Add generation counter to InitCodeMirrorForFile; stale completions (from a previous diff) are detected and disposed immediately - #3: Double-init guard — skip InitCodeMirrorForFile if _cmInstances already contains an entry for the fileIdx - #4: DisposeCmInstance replaced with snapshot-then-remove pattern; _pendingEditorInit cleared on Table toggle to prevent stale inits - #5: ReconstructOriginal/Modified now insert blank placeholder lines for inter-hunk gaps to preserve correct line numbering in CM MergeView - #6: Add SRI integrity hash (sha384) to codemirror-bundle.js script tag - #7: Replace O(n²) Files.IndexOf(file) with indexed for loop - #8: All catch blocks now log to Console.Error with [DiffView] prefix - NEW-1: Post-loop Clear() race eliminated — DisposeJsInstancesByIdAsync works on snapshotted arrays, never touches _cmInstances dictionary - Added _disposed guard to DisposeAsync for safe double-dispose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 7, 2026
…-hunk gaps - #1 (CRITICAL): Snapshot CM instance IDs before clearing dictionaries in OnParametersSet, preventing InvalidOperationException from enumerator invalidation and ensuring all JS instances are properly disposed - #2 (CRITICAL): Add generation counter to InitCodeMirrorForFile; stale completions (from a previous diff) are detected and disposed immediately - #3: Double-init guard — skip InitCodeMirrorForFile if _cmInstances already contains an entry for the fileIdx - #4: DisposeCmInstance replaced with snapshot-then-remove pattern; _pendingEditorInit cleared on Table toggle to prevent stale inits - #5: ReconstructOriginal/Modified now insert blank placeholder lines for inter-hunk gaps to preserve correct line numbering in CM MergeView - #6: Add SRI integrity hash (sha384) to codemirror-bundle.js script tag - #7: Replace O(n²) Files.IndexOf(file) with indexed for loop - #8: All catch blocks now log to Console.Error with [DiffView] prefix - NEW-1: Post-loop Clear() race eliminated — DisposeJsInstancesByIdAsync works on snapshotted arrays, never touches _cmInstances dictionary - Added _disposed guard to DisposeAsync for safe double-dispose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 7, 2026
…-hunk gaps - #1 (CRITICAL): Snapshot CM instance IDs before clearing dictionaries in OnParametersSet, preventing InvalidOperationException from enumerator invalidation and ensuring all JS instances are properly disposed - #2 (CRITICAL): Add generation counter to InitCodeMirrorForFile; stale completions (from a previous diff) are detected and disposed immediately - #3: Double-init guard — skip InitCodeMirrorForFile if _cmInstances already contains an entry for the fileIdx - #4: DisposeCmInstance replaced with snapshot-then-remove pattern; _pendingEditorInit cleared on Table toggle to prevent stale inits - #5: ReconstructOriginal/Modified now insert blank placeholder lines for inter-hunk gaps to preserve correct line numbering in CM MergeView - #6: Add SRI integrity hash (sha384) to codemirror-bundle.js script tag - #7: Replace O(n²) Files.IndexOf(file) with indexed for loop - #8: All catch blocks now log to Console.Error with [DiffView] prefix - NEW-1: Post-loop Clear() race eliminated — DisposeJsInstancesByIdAsync works on snapshotted arrays, never touches _cmInstances dictionary - Added _disposed guard to DisposeAsync for safe double-dispose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 14, 2026
…-hunk gaps - #1 (CRITICAL): Snapshot CM instance IDs before clearing dictionaries in OnParametersSet, preventing InvalidOperationException from enumerator invalidation and ensuring all JS instances are properly disposed - #2 (CRITICAL): Add generation counter to InitCodeMirrorForFile; stale completions (from a previous diff) are detected and disposed immediately - #3: Double-init guard — skip InitCodeMirrorForFile if _cmInstances already contains an entry for the fileIdx - #4: DisposeCmInstance replaced with snapshot-then-remove pattern; _pendingEditorInit cleared on Table toggle to prevent stale inits - #5: ReconstructOriginal/Modified now insert blank placeholder lines for inter-hunk gaps to preserve correct line numbering in CM MergeView - #6: Add SRI integrity hash (sha384) to codemirror-bundle.js script tag - #7: Replace O(n²) Files.IndexOf(file) with indexed for loop - #8: All catch blocks now log to Console.Error with [DiffView] prefix - NEW-1: Post-loop Clear() race eliminated — DisposeJsInstancesByIdAsync works on snapshotted arrays, never touches _cmInstances dictionary - Added _disposed guard to DisposeAsync for safe double-dispose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 19, 2026
CRITICAL fixes: - #1 Test isolation: add [Collection("BaseDir")], restore dir in finally blocks, register in TestSetup.Initialize() - #2 Stale state: only set _analyzerSessionName AFTER CreateSessionAsync succeeds, clear on failure - #3 Prompt injection: remove autonomous PR-creation instructions, change to report-only mode ("Do NOT autonomously create branches or PRs") MODERATE fixes: - #4 Lifecycle: implement IAsyncDisposable, add StopAsync() that awaits _analysisLoop with 5s timeout, nulls _analyzerSessionName - #5 (Feature activation deferred to UI integration PR) - #6 Model slug: fix "claude-sonnet-4-5" → "claude-sonnet-4.5" - #7 Timeout: wrap SendPromptAsync in 10-minute linked CancellationToken - #8 Interval validation: clamp to Math.Max(1, value) in settings setter and in StartAsync - #9 TailFile: use Queue<string> ring buffer instead of List, cap file read to MaxLogFileSizeBytes (10 MB) OTHER fixes: - #10 Remove TestHelpers class, use private CreateService() method - Thread safety: use Interlocked for AnalysisCount and LastAnalysisAt - Torn reads: snapshot GetAllSessions() with .ToList() - 14 tests (up from 8): new tests for TailFile, interval clamping, DisposeAsync, RunSingleAnalysis null guard, report-only prompt Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix Android TypeInitializerException: Static readonly path fields in
CopilotServiceandServerManagercrashed on Android becauseEnvironment.GetFolderPath(UserProfile)returns empty. Converted to lazy properties with Android-safe fallbacks (LocalApplicationData→Personal→Android.App.Application.Context.FilesDir).Fix safe area insets: Set
SafeAreaEdges="Container"on ContentPage. This is a .NET 10 breaking change whereContentPagedefaults toNone(edge-to-edge), causing the navbar to overlap the status bar.Update MAUI to 10.0.31: Pinned
Microsoft.Maui.ControlsandMicrosoft.AspNetCore.Components.WebView.Mauito explicit 10.0.31.Android connection defaults: Added
#if ANDROIDfallback to force Persistent mode with remote server connection.