Tab navigation + shared ChatMessageList component#4
Merged
Conversation
…, dashboard improvements - Tab/Shift+Tab cycles between sessions in chat view (via JS textarea handler) - Tab cycles between card inputs in Session Orchestrator - Clicking session name in orchestrator navigates to chat - Extracted shared ChatMessageList.razor component used by both Home and Dashboard - Session numbers shown in sidebar (1-9 badges) - Prev/Next session buttons in chat header - Dashboard card messages show full text (no truncation) - Native Mac Catalyst KeyCommandService infrastructure - Session LastUpdatedAt tracking - Cleaned up unused code and debug artifacts
PureWeen
added a commit
that referenced
this pull request
Feb 20, 2026
Concurrency fixes: - Swap _sessions before wiring event handler on reconnect (#2) - Block ALL events from orphaned handlers, not just terminal (#3) - Add lock(_imageQueueLock) to all image queue mutations (#4) including dequeue, reinsert, ClearQueue, rename, close, dispose - Clear IsResumed on error and watchdog paths (#5) - Add RunContinuationsAsynchronously to remaining TCS (#6) Architecture/contract fixes: - Add [JsonIgnore] to ShouldWarnOnStall, LastSimilarity (#7) - Fix ConsecutiveErrors increment-before-check ordering (#8) - Set IsCancelled on all non-success termination paths (#10) including stall, error-stall, max-iteration, OperationCanceled, empty-assignment error stall, and single-agent StopReflectionCycle - Add session dir deletion for ghost evaluator pruning (#12) - Add CompletedAt to StopReflectionCycle (#12 related) Already correct (no changes needed): - #9: CurrentIteration == 1 check was already fixed - #11: Comments already reference string-based stall detection Documentation: - Update stall detection from 'hash match' to 'string equality' - Update error handling to show ConsecutiveErrors (not ConsecutiveStalls) - Add IsCancelled invariant to exit conditions table - Add 5 new invariants: orphan gate, reconnect ordering, image queue locking, IsResumed clearing, TCS creation - Document empty-assignment retry behavior 817/817 tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 9, 2026
This was referenced Mar 15, 2026
PureWeen
added a commit
that referenced
this pull request
Mar 29, 2026
1. 🔴 Force-completion now uses ForceCompleteProcessingAsync instead of bare TrySetResult — properly clears IsProcessing + 9 companion fields (INV-1 compliant). Timed-out workers no longer show stuck spinner. 2. 🟡 Fix double-await of allDone that re-threw caught exceptions. Timeout path now collects results individually with per-task try/catch, then passes partial results array to synthesis. 3. 🟡 Cap queue drain to 3 per cycle to prevent unbounded lock holding. Remaining prompts get user-visible feedback and are processed on the next cycle. 4. 🟡 Console.WriteLine → Debug() in fleet error path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 2, 2026
PureWeen
added a commit
that referenced
this pull request
Apr 5, 2026
…-hunk gaps - #1 (CRITICAL): Snapshot CM instance IDs before clearing dictionaries in OnParametersSet, preventing InvalidOperationException from enumerator invalidation and ensuring all JS instances are properly disposed - #2 (CRITICAL): Add generation counter to InitCodeMirrorForFile; stale completions (from a previous diff) are detected and disposed immediately - #3: Double-init guard — skip InitCodeMirrorForFile if _cmInstances already contains an entry for the fileIdx - #4: DisposeCmInstance replaced with snapshot-then-remove pattern; _pendingEditorInit cleared on Table toggle to prevent stale inits - #5: ReconstructOriginal/Modified now insert blank placeholder lines for inter-hunk gaps to preserve correct line numbering in CM MergeView - #6: Add SRI integrity hash (sha384) to codemirror-bundle.js script tag - #7: Replace O(n²) Files.IndexOf(file) with indexed for loop - #8: All catch blocks now log to Console.Error with [DiffView] prefix - NEW-1: Post-loop Clear() race eliminated — DisposeJsInstancesByIdAsync works on snapshotted arrays, never touches _cmInstances dictionary - Added _disposed guard to DisposeAsync for safe double-dispose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 5, 2026
…-hunk gaps - #1 (CRITICAL): Snapshot CM instance IDs before clearing dictionaries in OnParametersSet, preventing InvalidOperationException from enumerator invalidation and ensuring all JS instances are properly disposed - #2 (CRITICAL): Add generation counter to InitCodeMirrorForFile; stale completions (from a previous diff) are detected and disposed immediately - #3: Double-init guard — skip InitCodeMirrorForFile if _cmInstances already contains an entry for the fileIdx - #4: DisposeCmInstance replaced with snapshot-then-remove pattern; _pendingEditorInit cleared on Table toggle to prevent stale inits - #5: ReconstructOriginal/Modified now insert blank placeholder lines for inter-hunk gaps to preserve correct line numbering in CM MergeView - #6: Add SRI integrity hash (sha384) to codemirror-bundle.js script tag - #7: Replace O(n²) Files.IndexOf(file) with indexed for loop - #8: All catch blocks now log to Console.Error with [DiffView] prefix - NEW-1: Post-loop Clear() race eliminated — DisposeJsInstancesByIdAsync works on snapshotted arrays, never touches _cmInstances dictionary - Added _disposed guard to DisposeAsync for safe double-dispose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 6, 2026
…-hunk gaps - #1 (CRITICAL): Snapshot CM instance IDs before clearing dictionaries in OnParametersSet, preventing InvalidOperationException from enumerator invalidation and ensuring all JS instances are properly disposed - #2 (CRITICAL): Add generation counter to InitCodeMirrorForFile; stale completions (from a previous diff) are detected and disposed immediately - #3: Double-init guard — skip InitCodeMirrorForFile if _cmInstances already contains an entry for the fileIdx - #4: DisposeCmInstance replaced with snapshot-then-remove pattern; _pendingEditorInit cleared on Table toggle to prevent stale inits - #5: ReconstructOriginal/Modified now insert blank placeholder lines for inter-hunk gaps to preserve correct line numbering in CM MergeView - #6: Add SRI integrity hash (sha384) to codemirror-bundle.js script tag - #7: Replace O(n²) Files.IndexOf(file) with indexed for loop - #8: All catch blocks now log to Console.Error with [DiffView] prefix - NEW-1: Post-loop Clear() race eliminated — DisposeJsInstancesByIdAsync works on snapshotted arrays, never touches _cmInstances dictionary - Added _disposed guard to DisposeAsync for safe double-dispose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 6, 2026
…-hunk gaps - #1 (CRITICAL): Snapshot CM instance IDs before clearing dictionaries in OnParametersSet, preventing InvalidOperationException from enumerator invalidation and ensuring all JS instances are properly disposed - #2 (CRITICAL): Add generation counter to InitCodeMirrorForFile; stale completions (from a previous diff) are detected and disposed immediately - #3: Double-init guard — skip InitCodeMirrorForFile if _cmInstances already contains an entry for the fileIdx - #4: DisposeCmInstance replaced with snapshot-then-remove pattern; _pendingEditorInit cleared on Table toggle to prevent stale inits - #5: ReconstructOriginal/Modified now insert blank placeholder lines for inter-hunk gaps to preserve correct line numbering in CM MergeView - #6: Add SRI integrity hash (sha384) to codemirror-bundle.js script tag - #7: Replace O(n²) Files.IndexOf(file) with indexed for loop - #8: All catch blocks now log to Console.Error with [DiffView] prefix - NEW-1: Post-loop Clear() race eliminated — DisposeJsInstancesByIdAsync works on snapshotted arrays, never touches _cmInstances dictionary - Added _disposed guard to DisposeAsync for safe double-dispose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 7, 2026
…-hunk gaps - #1 (CRITICAL): Snapshot CM instance IDs before clearing dictionaries in OnParametersSet, preventing InvalidOperationException from enumerator invalidation and ensuring all JS instances are properly disposed - #2 (CRITICAL): Add generation counter to InitCodeMirrorForFile; stale completions (from a previous diff) are detected and disposed immediately - #3: Double-init guard — skip InitCodeMirrorForFile if _cmInstances already contains an entry for the fileIdx - #4: DisposeCmInstance replaced with snapshot-then-remove pattern; _pendingEditorInit cleared on Table toggle to prevent stale inits - #5: ReconstructOriginal/Modified now insert blank placeholder lines for inter-hunk gaps to preserve correct line numbering in CM MergeView - #6: Add SRI integrity hash (sha384) to codemirror-bundle.js script tag - #7: Replace O(n²) Files.IndexOf(file) with indexed for loop - #8: All catch blocks now log to Console.Error with [DiffView] prefix - NEW-1: Post-loop Clear() race eliminated — DisposeJsInstancesByIdAsync works on snapshotted arrays, never touches _cmInstances dictionary - Added _disposed guard to DisposeAsync for safe double-dispose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 7, 2026
…-hunk gaps - #1 (CRITICAL): Snapshot CM instance IDs before clearing dictionaries in OnParametersSet, preventing InvalidOperationException from enumerator invalidation and ensuring all JS instances are properly disposed - #2 (CRITICAL): Add generation counter to InitCodeMirrorForFile; stale completions (from a previous diff) are detected and disposed immediately - #3: Double-init guard — skip InitCodeMirrorForFile if _cmInstances already contains an entry for the fileIdx - #4: DisposeCmInstance replaced with snapshot-then-remove pattern; _pendingEditorInit cleared on Table toggle to prevent stale inits - #5: ReconstructOriginal/Modified now insert blank placeholder lines for inter-hunk gaps to preserve correct line numbering in CM MergeView - #6: Add SRI integrity hash (sha384) to codemirror-bundle.js script tag - #7: Replace O(n²) Files.IndexOf(file) with indexed for loop - #8: All catch blocks now log to Console.Error with [DiffView] prefix - NEW-1: Post-loop Clear() race eliminated — DisposeJsInstancesByIdAsync works on snapshotted arrays, never touches _cmInstances dictionary - Added _disposed guard to DisposeAsync for safe double-dispose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 14, 2026
…-hunk gaps - #1 (CRITICAL): Snapshot CM instance IDs before clearing dictionaries in OnParametersSet, preventing InvalidOperationException from enumerator invalidation and ensuring all JS instances are properly disposed - #2 (CRITICAL): Add generation counter to InitCodeMirrorForFile; stale completions (from a previous diff) are detected and disposed immediately - #3: Double-init guard — skip InitCodeMirrorForFile if _cmInstances already contains an entry for the fileIdx - #4: DisposeCmInstance replaced with snapshot-then-remove pattern; _pendingEditorInit cleared on Table toggle to prevent stale inits - #5: ReconstructOriginal/Modified now insert blank placeholder lines for inter-hunk gaps to preserve correct line numbering in CM MergeView - #6: Add SRI integrity hash (sha384) to codemirror-bundle.js script tag - #7: Replace O(n²) Files.IndexOf(file) with indexed for loop - #8: All catch blocks now log to Console.Error with [DiffView] prefix - NEW-1: Post-loop Clear() race eliminated — DisposeJsInstancesByIdAsync works on snapshotted arrays, never touches _cmInstances dictionary - Added _disposed guard to DisposeAsync for safe double-dispose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 16, 2026
…rees Finding #3: Two concurrent CreateWorktreeAsync calls for the same repo+branch could both pass the reuse check and race on 'git worktree add -b <branch>'. Added per-branch SemaphoreSlim via ConcurrentDictionary to serialize creation for the same repo+branch. Finding #4: Worktree reuse only checked Directory.Exists — a corrupt or partially-deleted worktree would be reused even though git can't use it. Added IsValidWorktreeAsync that checks for .git file/dir AND runs git rev-parse --git-dir. Stale worktree entries are automatically cleaned up when the health check fails. Addresses review findings #3 and #4 (PR #527 v5). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 17, 2026
PureWeen
added a commit
that referenced
this pull request
Apr 17, 2026
CreateWorktreeAsync_SameBranch_ReusesExistingWorktree: verifies that calling CreateWorktreeAsync twice for the same repo+branch returns the same worktree entry without creating a duplicate. Uses state injection with a fake non-bare repo (has .git dir) so EnsureRepoCloneInCurrentRoot early-returns, and a minimal .git structure so IsValidWorktreeAsync passes. CreateWorktreeAsync_StaleWorktree_EvictsAndDoesNotReuse: verifies that a registered worktree whose directory doesn't exist is evicted from state rather than returned as a stale match. Addresses review finding #4 (missing behavioral worktree-reuse test, flagged by 3/3 reviewers). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Apr 17, 2026
1. TCS coupling (#2): complete old TCS with partial response via TrySetResult instead of TrySetCanceled, so orchestrator workers collect content gracefully instead of hitting the exception retry path 2. Race window (#4): set IsProcessing/IsResumed/ProcessingPhase on siblingState BEFORE handler registration (safe because state isn't published to _sessions yet), eliminating the ~16ms InvokeOnUI scheduling window 3. Behavioral test (#6): added SiblingReconnect_PreservesProcessingState_OnNewState 4. SessionStabilityTests: fixed comment-matching false positive in TryUpdate ordering assertion Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
7 tasks
PureWeen
added a commit
that referenced
this pull request
Apr 19, 2026
CRITICAL fixes: - #1 Test isolation: add [Collection("BaseDir")], restore dir in finally blocks, register in TestSetup.Initialize() - #2 Stale state: only set _analyzerSessionName AFTER CreateSessionAsync succeeds, clear on failure - #3 Prompt injection: remove autonomous PR-creation instructions, change to report-only mode ("Do NOT autonomously create branches or PRs") MODERATE fixes: - #4 Lifecycle: implement IAsyncDisposable, add StopAsync() that awaits _analysisLoop with 5s timeout, nulls _analyzerSessionName - #5 (Feature activation deferred to UI integration PR) - #6 Model slug: fix "claude-sonnet-4-5" → "claude-sonnet-4.5" - #7 Timeout: wrap SendPromptAsync in 10-minute linked CancellationToken - #8 Interval validation: clamp to Math.Max(1, value) in settings setter and in StartAsync - #9 TailFile: use Queue<string> ring buffer instead of List, cap file read to MaxLogFileSizeBytes (10 MB) OTHER fixes: - #10 Remove TestHelpers class, use private CreateService() method - Thread safety: use Interlocked for AnalysisCount and LastAnalysisAt - Torn reads: snapshot GetAllSessions() with .ToList() - 14 tests (up from 8): new tests for TailFile, interval clamping, DisposeAsync, RunSingleAnalysis null guard, report-only prompt Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 20, 2026
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tab/Shift+Tab Session Switching
Shared ChatMessageList Component
ChatMessageList.razor— single component rendering all message typesCompact=false, full mode with avatars/timestamps/tool details) and Dashboard.razor (Compact=true, card mode with role badges)UI Improvements
Infrastructure
KeyCommandServicefor native Mac Catalyst keyboard shortcutsLastUpdatedAttracking on sessions