This repository was archived by the owner on Nov 3, 2023. It is now read-only.
fix(checker): allow whitespace before inner functions and class#426
Merged
Conversation
2 tasks
Code0x58
approved these changes
Oct 24, 2019
Code0x58
suggested changes
Oct 24, 2019
There was a problem hiding this comment.
I just thought, there is the case of decorators around classes/functions, so that regex and test file could use @ cases.
For example it's fairly common to write a decorator that uses functions.wraps(...)
Avoid DeprecationWarning ("invalid escape sequence").
Contributor
Author
|
I updated the PR and also added a commit to fix some |
|
I just stumbled upon this PR. Is there anything that I can do to help it along or is it ready to merge? |
Contributor
Author
|
@ColinKennedy we're just waiting for a review by a project member. |
Member
|
Sorry for the long delays in response - I've been on back-to-back family vacation and business trips. I'll to catch up as soon as I can. |
Nurdok
suggested changes
Nov 22, 2019
Nurdok
approved these changes
Nov 30, 2019
daviddavis
pushed a commit
to daviddavis/pulp_ansible
that referenced
this pull request
Dec 13, 2019
daviddavis
pushed a commit
to daviddavis/plugin_template
that referenced
this pull request
Dec 13, 2019
Fix: PyCQA/pydocstyle#426 [noissue]
daviddavis
pushed a commit
to daviddavis/pulp_ansible
that referenced
this pull request
Dec 13, 2019
daviddavis
pushed a commit
to daviddavis/pulp_ansible
that referenced
this pull request
Dec 13, 2019
rytilahti
added a commit
to rytilahti/python-kasa
that referenced
this pull request
Apr 25, 2020
This is required as PyCQA/pydocstyle#426 does not fix the issue for async def'd inner functions.
This was referenced Apr 25, 2020
basnijholt
pushed a commit
to python-kasa/python-kasa
that referenced
this pull request
Apr 25, 2020
This is required as PyCQA/pydocstyle#426 does not fix the issue for async def'd inner functions.
2 tasks
3 tasks
peterjc
added a commit
to biopython/biopython
that referenced
this pull request
May 9, 2020
See psf/black#709 and PyCQA/pydocstyle#426 pydocstyle v5.0.0 (and thus flake8 D202) was relaxed to accept the blank lines added by black.
jcristau
added a commit
to jcristau/scriptworker-scripts
that referenced
this pull request
Feb 16, 2023
Once upon a time black and pydocstyle disagreed on blank lines before nested functions, and a comment would appease them both. Since then, the latter has been changed to not complain about a blank line (PyCQA/pydocstyle#426), and the former now complains about the missing blank line even with the comment (psf/black#3302).
jcristau
added a commit
to jcristau/scriptworker-scripts
that referenced
this pull request
Feb 17, 2023
Once upon a time black and pydocstyle disagreed on blank lines before nested functions, and a comment would appease them both. Since then, the latter has been changed to not complain about a blank line (PyCQA/pydocstyle#426), and the former now complains about the missing blank line even with the comment (psf/black#3302).
jcristau
added a commit
to jcristau/scriptworker-scripts
that referenced
this pull request
Feb 20, 2023
Once upon a time black and pydocstyle disagreed on blank lines before nested functions, and a comment would appease them both. Since then, the latter has been changed to not complain about a blank line (PyCQA/pydocstyle#426), and the former now complains about the missing blank line even with the comment (psf/black#3302).
jcristau
added a commit
to jcristau/scriptworker-scripts
that referenced
this pull request
Mar 6, 2023
Once upon a time black and pydocstyle disagreed on blank lines before nested functions, and a comment would appease them both. Since then, the latter has been changed to not complain about a blank line (PyCQA/pydocstyle#426), and the former now complains about the missing blank line even with the comment (psf/black#3302).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes D202: ("No blank lines allowed after function docstring") to
allow space below function docstrings with inner functions.
i.e. allows:
See comment from @cdeil in #361.
This is a follow-up of PR #395.
If you've added an error code or changed an error code behavior,
you should probably add or change a test case file under
tests/test_cases/and addit to the list under
tests/test_definitions.py.If you've added or changed a command line option,
you should probably add or change a test in
tests/test_integration.py.Make sure to include the PR number after you open and get one.