Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

fix: regex to catch inner functions doesn't catch asynchronous ones#467

Merged
sambhav merged 3 commits into
PyCQA:masterfrom
matthieucan:fix-whitespace-inner-async-function
Apr 29, 2020
Merged

fix: regex to catch inner functions doesn't catch asynchronous ones#467
sambhav merged 3 commits into
PyCQA:masterfrom
matthieucan:fix-whitespace-inner-async-function

Conversation

@matthieucan
Copy link
Copy Markdown
Contributor

@matthieucan matthieucan commented Apr 28, 2020

Hello, and thanks for the great tool!

This small PR fixes the case of detecting asynchronous inner functions, for D202 (inner classes and functions require an empty line between the outer function docstring and them). It is a follow-up of #426.

Please make sure to check for the following items:

  • Add unit tests and integration tests where applicable.
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

Copy link
Copy Markdown
Member

@sambhav sambhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

Comment thread docs/release_notes.rst Outdated
@sambhav sambhav merged commit 91764b3 into PyCQA:master Apr 29, 2020
@matthieucan matthieucan deleted the fix-whitespace-inner-async-function branch August 3, 2020 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants