Fix memory leak when calling Python from Rust#1806
Merged
Conversation
mejrs
approved these changes
Aug 17, 2021
Member
mejrs
left a comment
mejrs
left a comment
There was a problem hiding this comment.
Thanks!
The owned pointer isn't dereferenced
That's not what Py_DECREF does (see https://docs.python.org/3/c-api/refcounting.html for more on refcounting).
What happened here was that the raw pointer never had its reference count decremented, so the inner value was leaked and never deallocated. It's similar to mem::forget'ing a Rc in Rust.
Contributor
Author
|
Thanks for the correction! Updated the comment on the PR |
birkenfeld
requested changes
Aug 18, 2021
birkenfeld
approved these changes
Aug 18, 2021
Member
birkenfeld
left a comment
birkenfeld
left a comment
There was a problem hiding this comment.
LGTM, thanks! @davidhewitt needs cherry-pick to 0.14...
Member
|
auto-merge works! 🎉 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python::run_codetransforms the Rust code string to an owned pointer. The reference count to the owned pointer isn't decremented, which results in a memory leak when calling Python from Rust.This PR adds a missing
Py_DECREFcall on the owned pointer which fixes the memory leak.Fixes #1801.
Thanks to @mejrs for the tip on the fix.