Merged
Conversation
messense
reviewed
Aug 18, 2021
messense
requested changes
Aug 18, 2021
messense
reviewed
Aug 18, 2021
Co-authored-by: messense <messense@icloud.com>
birkenfeld
approved these changes
Aug 18, 2021
Merged
davidhewitt
pushed a commit
that referenced
this pull request
Aug 21, 2021
* update changelog * fix memory leak in PyModule::from_code * add PR link to changelog * Add Py_DECREF also when PyImport_ExecCodeModuleEx fails * Remove duplicated calls, simplify logic Co-authored-by: messense <messense@icloud.com> Co-authored-by: messense <messense@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
Py_DECREFtoPyModule::from_codesimilar to #1806.Py_CompileStringreturns a new owned pointer, and its reference count should be decremented, thus it's deallocated corretly.This should close #1801.