Conversation
Member
|
Could you add a news fragment as described in https://pyo3.rs/v0.18.1/contributing#documenting-changes? Thanks! (I did not trigger the CI as it will complain about the missing news fragment in any case.) I also think it would be good to include this in #3028. |
davidhewitt
added
CI-skip-changelog
davidhewitt
approved these changes
Mar 9, 2023
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks - I'm happy to pull this into the 0.18.2 release :)
(Although PyPy 3.10 is not out yet... coming soon?)
Contributor
Author
|
Probably we will release 3.10 in a month or so |
Member
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 10, 2023
3031: mangle exported functions for PyPy r=davidhewitt a=mattip I run HEAD of PyO3 with HEAD of some PyPy branches, and noticed that the py3.10 branch (which implements python3.10) [fails to properly build](https://github.com/pypy/binary-testing/actions/runs/4334873617/jobs/7569059852#step:6:179). The failure was a missing export: ``` /home/runner/work/binary-testing/binary-testing/pyo3/src/exceptions.rs:715: \ undefined reference to `PyExc_EncodingWarning' collect2: error: ld returned 1 exit status ``` So I grepped around in the code for `Py_3_10` to see what new functions were added and found a few that needed PyPy-specific exports. Co-authored-by: Matti Picus <matti.picus@gmail.com>
Contributor
|
Build failed: |
Member
|
bors retry |
Contributor
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Mar 12, 2023
3040: mangle exported functions for PyPy r=adamreichold a=mattip Continuation of #3031. This [turned up](https://github.com/pypy/binary-testing/actions/runs/4390086363/jobs/7688256133#step:6:179) in the run of PyPy 3.10 HEAD against PyO3 HEAD. Should I add a new news fragment or is the one from #3031 sufficient? Co-authored-by: Matti Picus <matti.picus@gmail.com>
bors bot
added a commit
that referenced
this pull request
Mar 15, 2023
3040: mangle exported functions for PyPy r=adamreichold a=mattip Continuation of #3031. This [turned up](https://github.com/pypy/binary-testing/actions/runs/4390086363/jobs/7688256133#step:6:179) in the run of PyPy 3.10 HEAD against PyO3 HEAD. Should I add a new news fragment or is the one from #3031 sufficient? Co-authored-by: Matti Picus <matti.picus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run HEAD of PyO3 with HEAD of some PyPy branches, and noticed that the py3.10 branch (which implements python3.10) fails to properly build. The failure was a missing export:
So I grepped around in the code for
Py_3_10to see what new functions were added and found a few that needed PyPy-specific exports.