mangle exported functions for PyPy#3040
Merged
Conversation
Member
|
I think the existing news fragment is sufficient. Thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 12, 2023
3040: mangle exported functions for PyPy r=adamreichold a=mattip Continuation of #3031. This [turned up](https://github.com/pypy/binary-testing/actions/runs/4390086363/jobs/7688256133#step:6:179) in the run of PyPy 3.10 HEAD against PyO3 HEAD. Should I add a new news fragment or is the one from #3031 sufficient? Co-authored-by: Matti Picus <matti.picus@gmail.com>
Contributor
|
Build failed: |
Member
|
@mattip Could you have a look at the build failure in https://github.com/PyO3/pyo3/actions/runs/4396220835/jobs/7698525481 ? Does this need a version limit? |
Contributor
Author
|
Yes, there should be a version guard. Only PyPy3.10 mangles the name of |
davidhewitt
reviewed
Mar 12, 2023
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Sorry I had a pending review comment, just posted - we can do #[cfg_attr(all(PyPy, Py_3_10), ...)]
Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
Member
|
bors retry |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #3031. This turned up in the run of PyPy 3.10 HEAD against PyO3 HEAD. Should I add a new news fragment or is the one from #3031 sufficient?