Makes PathBuf FromPyObject implementation work on all os.PathLike

[Tpt]

PyOS_FSPath is in abi3-py36

[adamreichold]

Isn't pathlib.Path also an os.PathLike, i.e. doesn't the first line basically include the second one?

[Tpt]

Indeed. I left the two lines for explictness because I assumed a lot of people are not used to os.PathLike. If you prefer I can remove the pathlib.Path line.

[adamreichold]

Personally, I would merge them and maybe use "pathlib.Path, os.PathLike" for the first column to stay explicit. But let's see what the other maintainers think.

[davidhewitt]

I was thinking of upending this table anyway and describing it from the Rust types (what they accept and what they convert to), so I'm ok with leaving this as two rows for now.

[davidhewitt]

Thanks - please accept the new licensing change in #3108 before we can merge this.

[Tpt]

@davidhewitt Thank you! Done.

[Tpt]

Pypy 3.10 fails with "undefined reference to `PyOS_FSPath'". What is strange is that it's supposed to be supported by Pypy 3.7+: https://doc.pypy.org/en/latest/release-v7.3.0.html#python-3-6-c-api

[adamreichold]

Is it possible that we need to link this under a different name using a PyPy prefix (we do this for many other symbols, c.f. e.g. #3040)? cc @mattip

[davidhewitt]

Yes, on all supported PyPy versions it looks like it is exported under the PyPy prefix: https://github.com/PyO3/python3-dll-a/blob/main/src/libpypy3-c.def#L449

(I would love to catch cases where our definition is wrong in pyo3-ffi-check, but so far I didn't work out a way to do this, probably rustdoc metadata is insufficient to do so.)

[Tpt]

Thank you! I have added the link_name attribute for Pypy.

(I would love to catch cases where our definition is wrong in pyo3-ffi-check, but so far I didn't work out a way to do this, probably rustdoc metadata is insufficient to do so.)

Dumb idea: if Pyo3 is supposed to cover all/most symbols expose al PyPy* symbol one can just grep each of them to check if there are present in PyO3 source code. This might allow to cover link names.