Skip to content

Add PyMemoryView type#3514

Merged
davidhewitt merged 4 commits intoPyO3:mainfrom
messense:memoryview
Oct 15, 2023
Merged

Add PyMemoryView type#3514
davidhewitt merged 4 commits intoPyO3:mainfrom
messense:memoryview

Conversation

@messense
Copy link
Copy Markdown
Member

@messense messense commented Oct 15, 2023

Provides a safe way to return a memoryview object to Python.

adamreichold
adamreichold reviewed Oct 15, 2023
View reviewed changes
Comment thread src/types/memoryview.rs
@adamreichold
Copy link
Copy Markdown
Member

adamreichold commented Oct 15, 2023

What is the relation of this to #2711 and #2792?

@messense
Copy link
Copy Markdown
Member Author

messense commented Oct 15, 2023

What is the relation of this to #2711 and #2792?

Ah, I was searching for memoryview and didn't find the existing issue. 😂

@messense
Copy link
Copy Markdown
Member Author

messense commented Oct 15, 2023

IMO this PR is a very limited version of #2792 that just opens door to return memoryview object, the existing PyBuffer already handles the need for accessing objects that implements buffer protocol in Rust (at least for my use case).

@adamreichold
Copy link
Copy Markdown
Member

adamreichold commented Oct 15, 2023

this PR is a very limited version of #2792

Ok, so we leave the original issue open.

davidhewitt
davidhewitt approved these changes Oct 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! Perhaps consider adding unit tests for the TryFrom implementations before merging? Otherwise please feel free to merge :)

@messense
Copy link
Copy Markdown
Member Author

messense commented Oct 15, 2023

Perhaps consider adding unit tests for the TryFrom implementations before merging?

Added in f4e64aa, but it looks like the ergonomics of the new TryFrom impls are not great because they collides with PyTryFrom::try_from so users need to disambiguate them manually.

@davidhewitt
Copy link
Copy Markdown
Member

davidhewitt commented Oct 15, 2023

Ah yes, we should probably remove PyTryFrom. #3516

@davidhewitt davidhewitt enabled auto-merge October 15, 2023 14:09
@davidhewitt davidhewitt added this pull request to the merge queue Oct 15, 2023
Merged via the queue into PyO3:main with commit f12f928 Oct 15, 2023
@messense messense deleted the memoryview branch October 16, 2023 02:54
@messense messense mentioned this pull request Oct 16, 2023
Merged
@davidhewitt davidhewitt mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

@adamreichold adamreichold adamreichold approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@messense @adamreichold @davidhewitt