feat(bindings/python): read APIs return memoryview instead of bytes to avoid copy#3310
Merged
Xuanwo merged 1 commit intoapache:mainfrom Oct 16, 2023
Merged
feat(bindings/python): read APIs return memoryview instead of bytes to avoid copy#3310Xuanwo merged 1 commit intoapache:mainfrom
memoryview instead of bytes to avoid copy#3310Xuanwo merged 1 commit intoapache:mainfrom
Conversation
github-actions
Bot
added
the
releases-note/feat
messense
force-pushed
the
python-memoryview
branch
2 times, most recently
from
a980a68 to
963122c
Compare
…s` to avoid copy
Before
```python
In [1]: import opendal
In [2]: op = opendal.Operator("memory")
In [3]: op.write("test", bytes(10 * 1024 * 1024))
In [4]: %timeit op.read("test")
627 µs ± 3.9 µs per loop (mean ± std. dev. of 7 runs, 1,000 loops each)
```
After
```python
In [1]: import opendal
In [2]: op = opendal.Operator("memory")
In [3]: op.write("test", bytes(10 * 1024 * 1024))
In [4]: %timeit op.read("test")
291 µs ± 761 ns per loop (mean ± std. dev. of 7 runs, 1,000 loops each)
```
messense
force-pushed
the
python-memoryview
branch
from
963122c to
dbbd64d
Compare
Xuanwo
reviewed
Oct 16, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
Unfortunately better performance comes with a price, we're no longer able to build
abi3wheels which means we need to build and publish one wheel per Python version, OS and CPU architecture.We can remove the
unsafeonce PyO3/pyo3#3514 is released.