Pyerr isinstance

[LilyFirefly]

Implements more of the Bound api from #3684.

[codspeed-hq]

CodSpeed Performance Report

Merging #3826 will degrade performances by 11.36%

_{Comparing LilyFoote:pyerr-isinstance (1d52ce4) with main (baf5c8e)}

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 76 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	LilyFoote:pyerr-isinstance	Change
⚡	list_via_downcast	185 ns	157.2 ns	+17.67%
⚡	not_a_list_via_downcast	272.2 ns	216.7 ns	+25.64%
❌	f64_from_pyobject	433.3 ns	488.9 ns	-11.36%

[davidhewitt]

Thanks again! Got a few suggestions for this one...

[davidhewitt]

With &Bound for the argument, this should work:

Suggested change

	self.is_instance_bound(py, ty.into_py(py).into_bound(py))
	self.is_instance_bound(py, &ty.as_borrowed())

Potentially are you willing to open a PR to recommend using as_borrowed() as the way to go from &PyAny to &Bound in the migration guide? e.g.

let gil_ref: &PyAny = ...;
let bound: &Bound<PyAny> = &gil_ref.as_borrowed();

(hopefully most user code won't need to care about this because all of it will just get migrated over, but this might still be useful for users to be aware as they rewrite their code...)

[davidhewitt]

Perfect, thanks again!