Skip to content

docs: document using as_borrowed in the Bound migration#3833

Merged
davidhewitt merged 1 commit intoPyO3:mainfrom
LilyFirefly:document-as-borrowed
Feb 14, 2024
Merged

docs: document using as_borrowed in the Bound migration#3833
davidhewitt merged 1 commit intoPyO3:mainfrom
LilyFirefly:document-as-borrowed

Conversation

@LilyFirefly
Copy link
Contributor

As suggested in #3826 (comment).

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 13, 2024

CodSpeed Performance Report

Merging #3833 will degrade performances by 16.95%

Comparing LilyFoote:document-as-borrowed (097f32c) with main (e308c8d)

Summary

⚡ 1 improvements
❌ 3 regressions
✅ 75 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main LilyFoote:document-as-borrowed Change
mapping_from_dict 272.2 ns 327.8 ns -16.95%
f64_from_pyobject 433.3 ns 377.8 ns +14.71%
sequence_from_list 272.2 ns 327.8 ns -16.95%
sequence_from_tuple 232.8 ns 260.6 ns -10.66%

@davidhewitt davidhewitt changed the title Document using as_borrowed in the Bound migration docs: document using as_borrowed in the Bound migration Feb 13, 2024
@davidhewitt
Copy link
Member

Thanks!

@davidhewitt davidhewitt added this pull request to the merge queue Feb 13, 2024
Merged via the queue into PyO3:main with commit a1e77c5 Feb 14, 2024
@LilyFirefly LilyFirefly deleted the document-as-borrowed branch February 14, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants