Tidy some usage of py.from_borrowed_ptr and py.from_borrowed_ptr_or_opt#3877
Merged
davidhewitt merged 2 commits intoPyO3:mainfrom Feb 23, 2024
Merged
Tidy some usage of py.from_borrowed_ptr and py.from_borrowed_ptr_or_opt#3877davidhewitt merged 2 commits intoPyO3:mainfrom
py.from_borrowed_ptr and py.from_borrowed_ptr_or_opt#3877davidhewitt merged 2 commits intoPyO3:mainfrom
Conversation
CodSpeed Performance ReportMerging #3877 will not alter performanceComparing Summary
|
davidhewitt
reviewed
Feb 20, 2024
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks! I have a few suggestions here mostly related to skipping unnecessary reference counting :)
LilyFirefly
force-pushed
the
tidy-from-borrowed-ptr
branch
from
c21d9b5 to
c602d8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.