Update new_closure_bound closure signature#3883
Merged
davidhewitt merged 3 commits intoPyO3:mainfrom Feb 23, 2024
Merged
Conversation
LilyFirefly
commented
Feb 22, 2024
LilyFirefly
commented
Feb 22, 2024
Icxolu
reviewed
Feb 22, 2024
LilyFirefly
force-pushed
the
pycfunction-new-closure
branch
2 times, most recently
from
6ab1624 to
fd380b1
Compare
davidhewitt
reviewed
Feb 22, 2024
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks for picking this one up! I have a suggestion, which is sort of for my own learning too 😂
davidhewitt
reviewed
Feb 23, 2024
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks both! One final thought from me...
Co-authored-by: Icxolu <10486322+Icxolu@users.noreply.github.com>
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
LilyFirefly
force-pushed
the
pycfunction-new-closure
branch
from
191ce6e to
c7b1e45
Compare
davidhewitt
approved these changes
Feb 23, 2024
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks both, this looks correct and elegantly implemented!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #3877, I noticed that
PyCFunction::new_closure_boundhas a bound that still uses the GIL ref api for the closure. This updates that to use theBoundapi instead.