Stable Rust

[konstin]

Fixes #5 🚀
Fixes #210
Fixed #697

Based on #961, I wanted to find out what's still missing and it turns out it's not much!

I've moved the performance improvements through specialization behind a unstable feature gate. There still two tests failing, which afaik test the behaviour of the specialized functions I deactivated.

Once #961 is ready, you should be able to cherry pick 97f6aa6.

[davidhewitt]

Also see #927 - though I think you go further here!

[konstin]

Sorry, totally missed #927. And nightly is definitely a better name for that feature.

[kngwyu]

@konstin
Thank you! In addition to trybuild tests, cargo clippy --all-features --all-targets looks failing

And nightly is definitely a better name for that feature.

Agreed.

[kngwyu]

@konstin
I'm sorry but I used force push for rebasing on the master.

[kngwyu]

Since this PR is almost ready, I think it's convenient to use this branch for migrating to stable.

Here's a TODO list:

• Documentation
  • Find the minimum stable version and note it on README.
    • It's 1.42.0 because of slice_pattern
    • 1.39.0
  • Document what is optimized by --features nightly
• CI
  • Use 'nightly' instead of 'minimum-nightly'.
  • Move rustfmt and clippy tests from 'minimum-nihgtly' to a stable one.
  • Add --features nightly test only for Github Actions?
    • Hmm, but there are many tests on Actions and I don't want to make the things more complex 🤔

[birkenfeld]

Is slice_pattern really needed? If that's the only blocker, I'd propose to support at least 1.39 which is what RHEL8 is shipping, for example...

[kngwyu]

Is slice_pattern really needed?

Though I like slice_pattern and it simplifies our codes, I think we can avoid it.

If that's the only blocker, I'd propose to support at least 1.39 which is what RHEL8 is shipping, for example...

I'm not sure it's the only blocker, but happy to try to down the version 🙂
Maybe we can support 1.36, which is the minimum required version of parking_lot.

[kngwyu]

I think we can support 1.39.0, but cannot support 1.38 because of const_vec_new.

[kngwyu]

Now the only TODO is documenting nightly flag, but where should the document be...? 🤔

[davidhewitt]

I suggest adding to advanced.md

[kngwyu]

@davidhewitt
Could you please take a glance at the documents?

[davidhewitt]

👍 I'll do my best to find some time to read this all tonight

[davidhewitt]

Looks really brilliant! I've made some small suggestions to wording of documentation - pick the suggestions you like 😄

[davidhewitt]

If this feature is just for convenience in CI scripts, maybe it's better to code it into the CI scripts instead of making this user-facing feature?

[kngwyu]

👍

[davidhewitt]

❤️

[kngwyu]

Thank you for the reviews!

[birkenfeld]

Congrats, this is a huge step!