Conversation
|
Given that #41 builds off this and provides solid functionality, I guess we should probably merge this once reviewed, and fix the bugs later. |
reelmatt
left a comment
There was a problem hiding this comment.
Aside from the visual bug you mentioned, I think this is good to merge. Should we want to "fix" the bug for a demo, I made a comment on one approach we could take.
To build on the note re: edge API triggering. The same problem seems to be present in reverse where the 'remove edge' API call fails because the Node it was connected to doesn't exist. This shouldn't be a problem in NetworkX, because removing a node also removes all associated edges. So to add to @reddigari's point, I think we want API calls triggered for:
- Edge creation only when done with the mouse
- Edge deletion only when 'delete' key is pressed
diegostruk
left a comment
There was a problem hiding this comment.
I think is good to merge this one before the other 2 PRs.
Integrates front-end API methods for adding and deleting edges. A few identified bugs:
DefaultPortWidgetcomponent?).This feels a little too buggy to merge, but I wanted to make the commits accessible.