Merged
Conversation
Prevents submission of config form until server responds that file was received.
Collaborator
Author
Execution works!! (at least on ReadCsvNode) |
reelmatt
approved these changes
Apr 7, 2020
matthew-t-smith
approved these changes
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This includes the commits from #40, so it will look much cleaner after that one is merged.)
When file is selected from configuration menu, it is uploaded to the server and saved with the filename:
<node ID>-<original name>.<original_extension>. The configuration form submit button is disabled until the server responds. The parameter to which the file corresponds (e.g.filepath_or_bufferis given the value of the filename on the server.This brought to my attention a couple of execution bugs:
The filename saved in the node options doesn't have the./tmpprefix, so pandas cannot find it. We will need to add a step in the node update view that replaces the value with the fully qualified FileStorage nameThe description field is inserted in the node options by the browser, and since the pandas function is called with (**options), it complains thatdescriptionis not a valid keyword arg.These issues are causing me to cool on the "pass the options dict as kwargs" strategy overall. Thoughts?