Remove previously deprecated objects. #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
After having made these changes it occurs to me that we could perhaps have raised some sort of DeprecationError for a version before completely removing these objects. Any thoughts? |
waylan
added
needs-review
mitya57
reviewed
May 24, 2022
Collaborator
mitya57
left a comment
mitya57
left a comment
There was a problem hiding this comment.
Looks good, just one typo noticed.
Collaborator
You mean one intermediate step between DeprecationWarning and complete removal? I don't see any sense, warnings are quite visible and I don't remember any other projects doing this. Some projects have distinct PendingDeprecationWarning and DeprecationWarning, though. |
Co-authored-by: Dmitry Shachnev <mitya57@users.noreply.github.com>
mitya57
approved these changes
May 27, 2022
waylan
added
approved
This was referenced Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely removes all objects which were deprecated back on version 3.0. We are now working on 3.4 so I think perhaps we can move forward with this. The one hesitation I have is that it is possible some older (unmaintained) extensions could stop working. However, given the time that has passed, and the fact that those extensions probably don't even support the new minimum Python version, I expect this to mostly be a non-issue.
So far, I have only made changes to the code. I still need to add something to the release notes.