Skip to content

Conversation

@venthur
Copy link
Contributor

@venthur venthur commented Jun 14, 2022

that's all :)

@waylan
Copy link
Member

waylan commented Jun 15, 2022

I recently noticed this failure elsewhere. It would appear that I introduced the error in #1260 and then failed to notice the failing test. We should probably fix it here. We have two options.

  1. Change codebase to code base (two words).
  2. Add codebase to the .spell-dict as a single word.

A quick search shows that a few dictionaries have added the single word, however they all appear to be the community editable type. Therefore, I am more inclined to go with two words unless someone can provide a good reason not to.

@waylan
Copy link
Member

waylan commented Jun 15, 2022

I just noticed that this PR is changing the php and pl tests. Those tests have been copied from their respective projects and are to be used as-is. In other words, we do not make any edits to those files. All edits to those files will need to be reverted for this to be accepted.

@waylan waylan added the requires-changes Awaiting updates after a review. label Jun 15, 2022
@venthur
Copy link
Contributor Author

venthur commented Jun 16, 2022

done and done :)

@waylan waylan merged commit 77fb7f1 into Python-Markdown:master Jun 17, 2022
@waylan waylan added approved The pull request is ready to be merged. and removed requires-changes Awaiting updates after a review. labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved The pull request is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants