Merged
Conversation
…ression") failed.
Bugfix for #66: preprocessor creation via from_params(model_type="reg…
…ar-regression Issue #75 PIGs for linear regression
…o the preprocessor constructor.
Bugfix for #66: from_params() and from_pipeline() make a wrong call t…
…lection univariate preselection based on RMSE, added new unit testing
…umerically and visually
…ession Issue#71 evaluator regression
…r - linear regression model does not have TWO columns).
…rward-selection Fixing model scoring problem
…tter" comparison when selecting best model.
…-evaluator-regression
sandervh14
approved these changes
Oct 5, 2021
Contributor
sandervh14
left a comment
sandervh14
left a comment
There was a problem hiding this comment.
Quickly went over this, we reviewed a lot already in detail in the issues we solved.
It's fine, GO.
If there would be minor bugs left, I'll notice them when validating on the industrial case Thursday morning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push all new developments to master in preparation of release of Cobra v1.1.0.
All commits from master are already in develop, so it is clean.