Skip to content

Issue #75 PIGs for linear regression#89

Merged
sborms merged 7 commits intodevelopfrom
issue-#75-pigs-for-linear-regression
Aug 12, 2021
Merged

Issue #75 PIGs for linear regression#89
sborms merged 7 commits intodevelopfrom
issue-#75-pigs-for-linear-regression

Conversation

@sandervh14
Copy link
Copy Markdown
Contributor

@sandervh14 sandervh14 commented Aug 12, 2021

Story Title

Evaluation - pigs_tables

Changes made

  • adapted PIG table & plot creation to support regression targets additionally
  • did a minor(!) expansion to the unit tests, the other tests I left in comments really require exposing a variable (df_plot) internal to the function + checking matplotlib's plot and ax object internals. Trying out the PIG plotting on our MVP regression case will show us immediately though if there is a problem left or not, anyway.

How does the solution address the problem

This PR will roll out PIGs for regression too.

Linked issues

Resolves #75.

@sandervh14 sandervh14 assigned sborms and unassigned sborms Aug 12, 2021
@sandervh14 sandervh14 requested a review from sborms August 12, 2021 10:37
@sandervh14 sandervh14 self-assigned this Aug 12, 2021
Copy link
Copy Markdown
Contributor

@sborms sborms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Smart that you rename the variables internally so it is clearer.

@sborms sborms merged commit 4db0cb0 into develop Aug 12, 2021
@sborms sborms deleted the issue-#75-pigs-for-linear-regression branch October 1, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants