Skip to content

Issue #66 preprocessor#86

Merged
sandervh14 merged 5 commits intomasterfrom
issue-#66-preprocessor
Aug 6, 2021
Merged

Issue #66 preprocessor#86
sandervh14 merged 5 commits intomasterfrom
issue-#66-preprocessor

Conversation

@sborms
Copy link
Copy Markdown
Contributor

@sborms sborms commented Aug 6, 2021

Issue #66 preprocessor

Issue #66 preprocessor

Changes made

  • added model_type in from_params()
  • added model_type as PreProcessor class variable
  • passed on imputation_strategy in from_params() call (bug fix)
  • modified one unit test a tiny bit - in general unit testing is meagre here but that's fine as most testing is done in underlying classes

Linked issues

Resolves #66

@sborms sborms requested a review from sandervh14 August 6, 2021 15:30
Copy link
Copy Markdown
Contributor

@sandervh14 sandervh14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okidoki!

@sandervh14 sandervh14 merged commit 7459b71 into master Aug 6, 2021
@sandervh14 sandervh14 deleted the issue-#66-preprocessor branch August 6, 2021 15:47
@sborms sborms restored the issue-#66-preprocessor branch August 6, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preprocessing - preprocessor

2 participants