Add musl aarch64 support at tier 4#1008
Conversation
Pull Request Test Coverage Report for Build 6749011978
💛 - Coveralls |
mtreinish
left a comment
There was a problem hiding this comment.
Thanks for doing this, I left some comments inline on the first job, but they apply to both jobs. Also did you spin up a test to make sure the build works? It'd be good to get confirmation the config will build the packages at least (since this stuff can be really finicky).
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
|
I launched a test workflow at https://github.com/IvanIsCoding/rustworkx/actions/runs/6684576474 for this |
|
I had to re-launch to exclude |
|
@mtreinish this is ready to merge I confirmed the jobs built the wheels we wanted: and The job shows as failed because it didn't have the credentials to upload to PyPI. But everything is fine |
mtreinish
left a comment
There was a problem hiding this comment.
LGTM, thanks for the updates and testing this.
* Wheel build for aarch64 * Add documentation for tier support * Apply suggestions from code review Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Update .github/workflows/wheels.yml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Simplify workflow pt2 * Skip manylinux on aarch64 build for musllinux * Fix YAML shenanigans --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Follow up to #992 and #997
This adds support for musl aarch64 wheels.
The wheels are unstested because of QEMU and NumPy. QEMU takes around 30+ minutes per Python version to build rustworkx. NumPy doesn't provide wheels for this architecture, hence adding tests would balloon the time considerably just to compile NumPy.
After #891, we can improve this architecture support by adding tests