Add support for Python 3.12 and musllinux to main#997
Merged
mergify[bot] merged 19 commits intoQiskit:mainfrom Oct 10, 2023
Merged
Add support for Python 3.12 and musllinux to main#997mergify[bot] merged 19 commits intoQiskit:mainfrom
mergify[bot] merged 19 commits intoQiskit:mainfrom
Conversation
As part of the 0.13.2 release we added support for Python 3.12 and musllinux to rustworkx. However, these changes did not happen on main yet. This commit applies the necessary changes to the main branch for the 0.14.0 and future releases. Also to simplify the configuration of the cibuildwheel jobs this combines Qiskit#753 into this PR so that the configuration is centralized in the pyproject.toml.
mtreinish
force-pushed
the
platform-support-updates
branch
from
c89a7aa to
8e9d57c
Compare
Pull Request Test Coverage Report for Build 6469003135
💛 - Coveralls |
IvanIsCoding
reviewed
Oct 6, 2023
IvanIsCoding
reviewed
Oct 7, 2023
Collaborator
IvanIsCoding
left a comment
IvanIsCoding
left a comment
There was a problem hiding this comment.
I think we might need to split the x86_64 and i686 jobs for Linux. i686 seems particularly more prone to error due to BLAS, so I think we should handle installation without BLAS separately
IvanIsCoding
reviewed
Oct 7, 2023
In Rust 1.74 the Rust programming language is raising their minimum support macOS version to 10.12, so rustworkx is raising it's supported version of macOS to match this.
IvanIsCoding
approved these changes
Oct 9, 2023
Collaborator
IvanIsCoding
left a comment
IvanIsCoding
left a comment
There was a problem hiding this comment.
LGTM, we just need to remove the trigger on push and it should be good to go
This reverts commit 57dd451.
Rachel-Eva
added a commit
to Rachel-Eva/rustworkx
that referenced
this pull request
Mar 16, 2026
* Add support for Python 3.12 and musllinux to main As part of the 0.13.2 release we added support for Python 3.12 and musllinux to rustworkx. However, these changes did not happen on main yet. This commit applies the necessary changes to the main branch for the 0.14.0 and future releases. Also to simplify the configuration of the cibuildwheel jobs this combines Qiskit#753 into this PR so that the configuration is centralized in the pyproject.toml. * DNM: Test wheel build configuration * Remove testtools usage from test suite * Don't require blas on numpy install * Fix docs typo * Drop musl on aarch64 * Try installing openblas to fix numpy build * Fix toml syntax * Adjust override to use allowed fields only * Fix toml syntax again * Switch back to pip command * Downgrade pp64le to tier 4 and skip tests * Fix apk command copy paste error * Raise minimum supported macOS version to 10.12 In Rust 1.74 the Rust programming language is raising their minimum support macOS version to 10.12, so rustworkx is raising it's supported version of macOS to match this. * Tweak test skip regex * Split arm into 2 jobs * Revert "DNM: Test wheel build configuration" This reverts commit 57dd451.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the 0.13.2 release we added support for Python 3.12 and musllinux to rustworkx. However, these changes did not happen on main yet. This commit applies the necessary changes to the main branch for the 0.14.0 and future releases. Also to simplify the configuration of the cibuildwheel jobs this combines #753 into this PR so that the configuration is centralized in the pyproject.toml.