FEAT: Add jitted function for drawing#391
Merged
jstac merged 2 commits intoQuantEcon:masterfrom Mar 7, 2018
Merged
Conversation
Member
|
Some comments:
|
oyamad
reviewed
Mar 7, 2018
|
|
||
|
|
||
| @jit(nopython=True) | ||
| def discrete_rv(p_vals, cum_sum=None, size=1000, seed=0): |
Member
There was a problem hiding this comment.
The default value for seed must be None.
04b0a72 to
f543a9e
Compare
Member
Author
|
I agree with those comments. @jstac What do you think? |
dfacbc9 to
b87ed1a
Compare
b87ed1a to
081163f
Compare
Contributor
Contributor
|
@mmcky I'm going to go ahead and merge this, i hope that's OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a jitted function for drawing discrete random variables. Note that
DiscreteRV.drawno longer usescheck_random_stateas Numba supports top-level functions from the numpy.random module, but does not allow you to create individual RandomState instances.Close #390