Merged
Conversation
Implemented with `@generated_jit(nopython=True)`
Contributor
|
@mmcky I'm fully in favor of this PR and it would help me clean up master if we could move quickly on it. Thanks. |
QBatista
reviewed
Mar 11, 2018
| def draw(cdf, size=None): | ||
| """ | ||
| Generate a random sample according to the cumulative distribution | ||
| given by `cdf`. Jit-complied by Numba in nonptython mode. |
Member
There was a problem hiding this comment.
Did you mean "Jit-compiled by Numba in nopython mode"?
Contributor
|
I think this PR can be merged. @oyamad can you apply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #393.
(Also revert the changes by #391, as we should not have both
random_choiceandrandom.draw.)