Sentiment analysis by jnelson16 · Pull Request #33 · QuantGov/quantgov

jnelson16 · 2017-11-13T21:56:33Z

Also raises errors if certain modules are not installed

complexity builtins

in setup.py

nltk fixes

nltk troubles

OliverSherouse · 2017-11-21T16:43:39Z

quantgov/corpora/utils.py

+
+@decorator
+def check_nltk(func, *args, **kwargs):
+    if args[-1] is None:


Why are we passing this as an argument? It's available module wide. Just do if NLTK

OliverSherouse · 2017-11-21T16:43:55Z

quantgov/corpora/utils.py

+
+@decorator
+def check_textblob(func, *args, **kwargs):
+    if args[-2] is None:


Same thing here. if textblob is None

OliverSherouse · 2017-11-21T16:46:32Z

setup.cfg

 addopts = --flake8
 flake8-ignore = 
-    *.py W391 W503
+    *.py W391 W503 F821


We can't ignore this; it's an important error. Where are you getting it?

OliverSherouse · 2017-11-21T16:49:55Z

setup.py

+            'textblob',
+            'nltk',
+            'decorator'
+        ]


Decorator needs to be in the main requires, since it's used regardless. I don't like the name builtins; maybe nlp?

OliverSherouse · 2017-11-21T16:51:35Z

quantgov/corpora/builtins.py

+        help='Performs sentiment analysis on the text',
+        arguments=[
+            quantgov.utils.CLIArg(
+                flags=('--analyzer'),


Did I tell you to do this? If not, it's good forward thinking! But a bad variable name. Maybe "backend"?

OliverSherouse · 2017-11-21T16:52:50Z

quantgov/corpora/builtins.py

+        sentences = textblob.TextBlob(doc.text).sentences
+        return doc.index + (round(sum(len(
+            sentence.words) for sentence in sentences) /
+            len(sentences), int(precision)),)


What if the user wants unrounded output? Maybe if precision = None return unrounded, otherwise the rounded version.

OliverSherouse · 2017-11-21T16:54:24Z

quantgov/corpora/builtins.py

 import quantgov

+try:
+    import nltk.corpus


Not to make this more complicated than it already is, but we need specific NLTK corpora, right? We should check for those and either download them automatically or (probably better) tell the user how to do so.

jnelson16 · 2017-11-28T19:04:17Z

@OliverSherouse ready for another look

* Inaugurated 0.4.0 dev series * Sentiment analysis (#33) Closes #11 #12 #13 and adds Sentiment analysis! * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * if it aint broke... * textblob sentiment * tests and error raising * fixed install req * pep8 fixes * code review updates * fix travis file * import fixes * small fix * Test corpora (#35) * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * new corpora in English!! * hotfix to add timestamp as corpus identifier * Skl compatibility (#41) * Add sklearn 0.17 compatibility Paper over library reorganization. * renamed corpora to corpus, added deprecation warning (#42) * renamed corpora to corpus, added deprecation warning * moved load_driver and set up for future forcing of full imports of submodules Closes #31 * S3 drivers (#44) * initial working commit for s3 driver and database driver * removing 3.6 formatting * adding extra requirements list * adding basic s3 driver test * Removing unnecessary function * This ain't 2007 * test updates * adding s3driver to new corpus structure * Rounding (#45) * bumped version

* Inaugurated 0.4.0 dev series * Sentiment analysis (#33) Closes #11 #12 #13 and adds Sentiment analysis! * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * if it aint broke... * textblob sentiment * tests and error raising * fixed install req * pep8 fixes * code review updates * fix travis file * import fixes * small fix * Test corpora (#35) * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * if it aint broke... * new corpora in English!! * hotfix to add timestamp as corpus identifier * Skl compatibility (#41) * Add sklearn 0.17 compatibility Paper over library reorganization. * renamed corpora to corpus, added deprecation warning (#42) * renamed corpora to corpus, added deprecation warning * moved load_driver and set up for future forcing of full imports of submodules Closes #31 * S3 drivers (#44) * initial working commit for s3 driver and database driver * removing 3.6 formatting * adding extra requirements list * adding basic s3 driver test * Removing unnecessary function * This ain't 2007 * test updates * adding s3driver to new corpus structure * Rounding (#45) * bumped version * Fix NLTK loading bug Fix evaluation order when NLTK is not present

* hotfix to add timestamp as corpus identifier (#39) * bumped version * Release 0.4 (#47) * Inaugurated 0.4.0 dev series * Sentiment analysis (#33) Closes #11 #12 #13 and adds Sentiment analysis! * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * if it aint broke... * textblob sentiment * tests and error raising * fixed install req * pep8 fixes * code review updates * fix travis file * import fixes * small fix * Test corpora (#35) * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * new corpora in English!! * hotfix to add timestamp as corpus identifier * Skl compatibility (#41) * Add sklearn 0.17 compatibility Paper over library reorganization. * renamed corpora to corpus, added deprecation warning (#42) * renamed corpora to corpus, added deprecation warning * moved load_driver and set up for future forcing of full imports of submodules Closes #31 * S3 drivers (#44) * initial working commit for s3 driver and database driver * removing 3.6 formatting * adding extra requirements list * adding basic s3 driver test * Removing unnecessary function * This ain't 2007 * test updates * adding s3driver to new corpus structure * Rounding (#45) * bumped version * Fix NLTK loading bug Fix evaluation order when NLTK is not present

Jonathan Nelson added 20 commits November 6, 2017 13:32

complexity

5028e17

complexity builtins

f540d17

complexity builtins with tests

6731383

Merge pull request #1 from jnelson16/complexity

7fc8d01

complexity builtins

code review updates

1aabb9a

option tests

43f4d37

added nltk requirement

d121398

in setup.py

add pip install to .travis.yml

a5c15c9

nltk fixes

c1ebb76

Merge pull request #2 from jnelson16/troubleshoot

1da893e

nltk fixes

another nltk fix

d731de1

last nltk fix?

1b0e35a

you know the drill

b1e142e

Update .travis.yml

41b17f8

nltk troubles

842204b

Merge pull request #3 from jnelson16/nltk-troubles

ead81fc

nltk troubles

some final cleanup

3f95a98

if it aint broke...

f9bd220

textblob sentiment

61312c3

tests and error raising

0bdff3d

jnelson16 requested a review from OliverSherouse November 13, 2017 21:56

Jonathan Nelson added 2 commits November 17, 2017 11:33

fixed install req

7c7d1d2

pep8 fixes

bdac274

OliverSherouse mentioned this pull request Nov 21, 2017

complexity builtins #32

Closed

OliverSherouse suggested changes Nov 27, 2017

View reviewed changes

Jonathan Nelson added 4 commits November 28, 2017 13:30

code review updates

a20bd12

fix travis file

1876407

import fixes

981e075

small fix

f0f43f3

OliverSherouse approved these changes Nov 28, 2017

View reviewed changes

OliverSherouse merged commit e3f9c7a into QuantGov:dev Nov 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sentiment analysis#33

Sentiment analysis#33
OliverSherouse merged 26 commits intoQuantGov:devfrom
jnelson16:sentiment

jnelson16 commented Nov 13, 2017

Uh oh!

OliverSherouse Nov 21, 2017

Uh oh!

OliverSherouse Nov 21, 2017

Uh oh!

OliverSherouse Nov 21, 2017

Uh oh!

OliverSherouse Nov 21, 2017

Uh oh!

OliverSherouse Nov 21, 2017

Uh oh!

OliverSherouse Nov 21, 2017

Uh oh!

OliverSherouse Nov 21, 2017

Uh oh!

jnelson16 commented Nov 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jnelson16 commented Nov 13, 2017

Uh oh!

OliverSherouse Nov 21, 2017

Choose a reason for hiding this comment

Uh oh!

OliverSherouse Nov 21, 2017

Choose a reason for hiding this comment

Uh oh!

OliverSherouse Nov 21, 2017

Choose a reason for hiding this comment

Uh oh!

OliverSherouse Nov 21, 2017

Choose a reason for hiding this comment

Uh oh!

OliverSherouse Nov 21, 2017

Choose a reason for hiding this comment

Uh oh!

OliverSherouse Nov 21, 2017

Choose a reason for hiding this comment

Uh oh!

OliverSherouse Nov 21, 2017

Choose a reason for hiding this comment

Uh oh!

jnelson16 commented Nov 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants