Merged
Conversation
jnelson16
reviewed
Apr 11, 2018
Member
jnelson16
left a comment
jnelson16
left a comment
There was a problem hiding this comment.
Test passes on my laptop, so this is probably good to go. I still want to try running one of the state corpora through the new driver, I'll let you know how that goes.
quantgov/corpora/structures.py
Outdated
| """ Filter paths based on index values. """ | ||
| raise NotImplementedError | ||
|
|
||
| def gen_indces_and_paths(self): |
| RecursiveDirectoryCorpusDriver, | ||
| NamePatternCorpusDriver, | ||
| IndexDriver | ||
| IndexDriver, |
Member
There was a problem hiding this comment.
@OliverSherouse Is there a reason this is not called IndexCorpusDriver, to follow the pattern above?
Contributor
There was a problem hiding this comment.
Nope. Let's add that as a bug and rename for 1.0
tests/test_corpora.py
Outdated
| rows.append((letter, number, path)) | ||
| index_path = directory.join('index.csv') | ||
| with index_path.open('w', encoding='utf-8') as outf: | ||
| outf.write(u'letter,number,path\n') |
Member
There was a problem hiding this comment.
Should we be using the csv.writerows method for this? Or is this a more efficient way for testing purposes? @OliverSherouse
Contributor
There was a problem hiding this comment.
Not more efficient, particularly, though not really a problem, either.
Member
|
I have an S3Driver working with the Wyoming (or as @OliverSherouse calls it, Wisconsin) corpus! |
Contributor
OliverSherouse
left a comment
OliverSherouse
left a comment
There was a problem hiding this comment.
Fix small bugs and a few questions.
tests/test_corpora.py
Outdated
| rows.append((letter, number, path)) | ||
| index_path = directory.join('index.csv') | ||
| with index_path.open('w', encoding='utf-8') as outf: | ||
| outf.write(u'letter,number,path\n') |
Contributor
There was a problem hiding this comment.
Why do we have u strings? This ain't 2007, we're not writing python 2!
| outf.write(u'letter,number,path\n') | ||
| outf.write(u'\n'.join(','.join(row) for row in rows)) | ||
| return quantgov.corpora.S3Driver(str(index_path), | ||
| bucket='quantgov-databanks') |
Contributor
There was a problem hiding this comment.
Will people outside the core dev team be able to run these tests?
Contributor
Author
There was a problem hiding this comment.
As long as they have aws credentials for boto I believe so, since the bucket is public.
OliverSherouse
approved these changes
Apr 13, 2018
OliverSherouse
added a commit
that referenced
this pull request
Apr 17, 2018
* Inaugurated 0.4.0 dev series * Sentiment analysis (#33) Closes #11 #12 #13 and adds Sentiment analysis! * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * if it aint broke... * textblob sentiment * tests and error raising * fixed install req * pep8 fixes * code review updates * fix travis file * import fixes * small fix * Test corpora (#35) * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * new corpora in English!! * hotfix to add timestamp as corpus identifier * Skl compatibility (#41) * Add sklearn 0.17 compatibility Paper over library reorganization. * renamed corpora to corpus, added deprecation warning (#42) * renamed corpora to corpus, added deprecation warning * moved load_driver and set up for future forcing of full imports of submodules Closes #31 * S3 drivers (#44) * initial working commit for s3 driver and database driver * removing 3.6 formatting * adding extra requirements list * adding basic s3 driver test * Removing unnecessary function * This ain't 2007 * test updates * adding s3driver to new corpus structure * Rounding (#45) * bumped version
OliverSherouse
added a commit
that referenced
this pull request
Apr 17, 2018
* Inaugurated 0.4.0 dev series * Sentiment analysis (#33) Closes #11 #12 #13 and adds Sentiment analysis! * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * if it aint broke... * textblob sentiment * tests and error raising * fixed install req * pep8 fixes * code review updates * fix travis file * import fixes * small fix * Test corpora (#35) * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * if it aint broke... * new corpora in English!! * hotfix to add timestamp as corpus identifier * Skl compatibility (#41) * Add sklearn 0.17 compatibility Paper over library reorganization. * renamed corpora to corpus, added deprecation warning (#42) * renamed corpora to corpus, added deprecation warning * moved load_driver and set up for future forcing of full imports of submodules Closes #31 * S3 drivers (#44) * initial working commit for s3 driver and database driver * removing 3.6 formatting * adding extra requirements list * adding basic s3 driver test * Removing unnecessary function * This ain't 2007 * test updates * adding s3driver to new corpus structure * Rounding (#45) * bumped version * Fix NLTK loading bug Fix evaluation order when NLTK is not present
OliverSherouse
added a commit
that referenced
this pull request
May 21, 2018
* hotfix to add timestamp as corpus identifier (#39) * bumped version * Release 0.4 (#47) * Inaugurated 0.4.0 dev series * Sentiment analysis (#33) Closes #11 #12 #13 and adds Sentiment analysis! * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * if it aint broke... * textblob sentiment * tests and error raising * fixed install req * pep8 fixes * code review updates * fix travis file * import fixes * small fix * Test corpora (#35) * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * new corpora in English!! * hotfix to add timestamp as corpus identifier * Skl compatibility (#41) * Add sklearn 0.17 compatibility Paper over library reorganization. * renamed corpora to corpus, added deprecation warning (#42) * renamed corpora to corpus, added deprecation warning * moved load_driver and set up for future forcing of full imports of submodules Closes #31 * S3 drivers (#44) * initial working commit for s3 driver and database driver * removing 3.6 formatting * adding extra requirements list * adding basic s3 driver test * Removing unnecessary function * This ain't 2007 * test updates * adding s3driver to new corpus structure * Rounding (#45) * bumped version * Fix NLTK loading bug Fix evaluation order when NLTK is not present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.