You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
JLArrays.jl is a mocking package from GPUArrays.jl that allows us to test array semantics and behavior without requiring a GPU or working CUDA/ROCm install. I added an extension here so that packages which depend on StridedViews can use JLArrays to test GPU integration on machines which don't have GPUs.
Looks good, however one main question here just to check that I am following:
Is the goal to try and rewrite/add to the Strided kernels an implementation that does not rely on scalar indexing? While I agree that it would be nice to have such functionality for the GPUarrays, I would guess that it would look like custom kernels (in the same spirit of https://github.com/JuliaGPU/GPUArrays.jl/blob/88dcf9c24b4d68e5e467135e1c6420fea459d1ae/src/host/linalg.jl#L712-L756). Does that then work with JLArrays, or should we then manually overload that to allow the scalar indexing in the mapreduce_kernel!?
Yes, the idea would be we would eventually write some custom kernels with KernelAbstractions. These can be directly used with JLArrays in a "CPU only" way, so we would be able to test that everything at least ran and gave correct results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JLArrays.jlis a mocking package fromGPUArrays.jlthat allows us to test array semantics and behavior without requiring a GPU or working CUDA/ROCm install. I added an extension here so that packages which depend onStridedViewscan useJLArraysto test GPU integration on machines which don't have GPUs.