-
Notifications
You must be signed in to change notification settings - Fork 0
CircleCI: fix l2blob tests and op-program-compat #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
op-e2e/config/init.go
Outdated
| "isSoulBackedByNative": true, | ||
| "useSoulGasToken": true, | ||
| "isSoulBackedByNative": true, | ||
| "l2GenesisBlobTimeOffset": "0x0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And looks like this change is also unnecessary since it's handled in the test here. The l2blob tests can already pass in the latest op-e2e branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still fails without useSoulGasToken set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean l2GenesisBlobTimeOffset is not needed, this is what this PR is changing, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I meant l2GenesisBlobTimeOffset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's failing because we changed require.ErrorContains to require.NoError in this PR: ethstorage#140 . Maybe we can revert this change since l2 blob is not enabled by default and only enabled in the l2 blob e2e test. This way we don't need to touch the tests of upstream.
Origin log can be found here
The reason is that
l2GenesisBlobTimeOffsetis not set.After
"l2GenesisBlobTimeOffset": "0x0",is applied, another error occurs due to emptyBlobBaseFee:The issue fixed after
vmenv.Context.BlobBaseFeeis set inop-program/client/l2/engineapi/block_processor.go.This also fixes op-program-compat as the same root cause.