Skip to content

Conversation

@syntrust
Copy link

@syntrust syntrust commented Mar 7, 2025

Origin log can be found here
The reason is that l2GenesisBlobTimeOffset is not set.

After "l2GenesisBlobTimeOffset": "0x0", is applied, another error occurs due to empty BlobBaseFee:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x549d37]

goroutine 1 [running]:
math/big.(*Int).Mul(0xc006c6f218, 0xc006c6f1f8, 0x0)
        /home/circleci/.mise-data/installs/go/1.22.7/src/math/big/int.go:194 +0x97
github.com/ethereum/go-ethereum/core.(*stateTransition).innerExecute(0xc006c6f440)
        /home/circleci/go/pkg/mod/github.com/!quarkchain/op-geth@v0.0.0-20250217080034-97596a48ef97/core/state_transition.go:871 +0x10ca
github.com/ethereum/go-ethereum/core.(*stateTransition).execute(0xc006c6f440)
        /home/circleci/go/pkg/mod/github.com/!quarkchain/op-geth@v0.0.0-20250217080034-97596a48ef97/core/state_transition.go:666 +0xf7
github.com/ethereum/go-ethereum/core.ApplyMessage(0xc005220000, 0xc00047b2c0, 0xc0043025d8)

The issue fixed after vmenv.Context.BlobBaseFee is set in op-program/client/l2/engineapi/block_processor.go.
This also fixes op-program-compat as the same root cause.

"isSoulBackedByNative": true,
"useSoulGasToken": true,
"isSoulBackedByNative": true,
"l2GenesisBlobTimeOffset": "0x0",
Copy link

@blockchaindevsh blockchaindevsh Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And looks like this change is also unnecessary since it's handled in the test here. The l2blob tests can already pass in the latest op-e2e branch.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still fails without useSoulGasToken set

Copy link

@blockchaindevsh blockchaindevsh Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean l2GenesisBlobTimeOffset is not needed, this is what this PR is changing, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant l2GenesisBlobTimeOffset

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's failing because we changed require.ErrorContains to require.NoError in this PR: ethstorage#140 . Maybe we can revert this change since l2 blob is not enabled by default and only enabled in the l2 blob e2e test. This way we don't need to touch the tests of upstream.

@syntrust syntrust merged commit 1e2aca5 into op-es Mar 24, 2025
@syntrust syntrust deleted the dl-fixcc-4 branch May 29, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants