Skip to content

CircleCI: fix l2blob tests and op-program-compat #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syntrust merged 4 commits into from
Mar 24, 2025
Merged

CircleCI: fix l2blob tests and op-program-compat #22

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c84bba8
fix l2blob tests
syntrust Mar 7, 2025
920b5f1
Merge branch 'op-es' of https://github.com/QuarkChain/optimism into d…
syntrust Mar 18, 2025
70ed7af
revert
syntrust Mar 18, 2025
9382b56
fix comments
syntrust Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions op-e2e/actions/upgrades/dencun_fork_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ func TestDencunBlobTxRPC(gt *testing.T) {
cl := engine.EthClient()
tx := aliceSimpleBlobTx(t, dp)
err := cl.SendTransaction(context.Background(), tx)
require.NoError(t, err, "must accept blob tx via RPC")
require.ErrorContains(t, err, "transaction type not supported")
}

// TestDencunBlobTxInTxPool tries to insert a blob tx directly into the tx pool, it should not be accepted.
Expand All @@ -217,7 +217,7 @@ func TestDencunBlobTxInTxPool(gt *testing.T) {
engine := newEngine(t, sd, log)
tx := aliceSimpleBlobTx(t, dp)
errs := engine.Eth.TxPool().Add([]*types.Transaction{tx}, true, true)
require.NoError(t, errs[0], "must accept blob tx In tx pool")
require.ErrorContains(t, errs[0], "transaction type not supported")
}

// TestDencunBlobTxInclusion tries to send a Blob tx to the L2 engine, it should not be accepted.
Expand All @@ -235,5 +235,5 @@ func TestDencunBlobTxInclusion(gt *testing.T) {

sequencer.ActL2StartBlock(t)
err := engine.EngineApi.IncludeTx(tx, dp.Addresses.Alice)
require.NoError(t, err, "must inlcude blob tx")
require.ErrorContains(t, err, "invalid L2 block (tx 1): failed to apply transaction to L2 block (tx 1): transaction type not supported")
}