Button: restore "inactive" prop; typescript-ify

[adamhooper]

Relates to QZ-151 in that I tried calling <Button> from typescript and this error appeared.

It looks like "inactive" might have been removed in error. qz-react uses it in seven different calls.

[linear]

QZ-151 Social-login buttons submit the form

Steps to reproduce:

1. Open https://qz.com/login/
2. Enter username/password
3. Click "Log in with Apple ID"

Expected results: the button click opens the 'Apple ID' popup

Actual results: the button click opens the 'Apple ID' popup and logs you in

This is because a <button> is a "submit" button by default; we need to set type="button" (or move it outside the form) to prevent that.

[Bhammy]

Hmm - why make onClick optional? It seems like a useful pointer to say that maybe another kind of element is required

[adamhooper]

A <button type="submit"> doesn't need (and shouldn't have) an onClick.

I think this nit should be obvious when calling the component. But when I converted to Typescript, I erroneously set this to "required" and then had to backtrack when the callers threw type-safety errors. So I've added an inline comment to save the next developer the same embarrassment.

[Bhammy]

🤦 of course! Good points.