Remove Link component and refactor Button #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2020
jesswray
pushed a commit
that referenced
this pull request
Aug 21, 2020
* remove Link from Callout story examples * replace ButtonLink with ButtonLabel * fix imports * create inline prop for button * update docs with info about ButtonLabel * remove react-router-dom
Bhammy
pushed a commit
that referenced
this pull request
Oct 20, 2020
* remove Link from Callout story examples * replace ButtonLink with ButtonLabel * fix imports * create inline prop for button * update docs with info about ButtonLabel * remove react-router-dom
adamhooper
added a commit
that referenced
this pull request
Aug 23, 2021
It's used all over qz-react. It was removed in #24 without any explanation. Seems like an oversight.
adamhooper
added a commit
that referenced
this pull request
Aug 24, 2021
It's used all over qz-react. It was removed in #24 without explanation. Seems like an oversight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Link component brings app-specific logic that belongs in qz.com only. It also means Prism has a dependency on
react-router-dom. It is therefore not in the spirit of a platform-agnostic component library to keep theLinkcomponent in Prism.This PR removes
Link, and refactors the Button component to accommodate this change. Specifically, it replacesButtonLinkwithButtonLabel, a styledspanthat can be optionally wrapped in anatag (or anything else) by the consumer.This PR also:
inlineto control the behavior and appearance of the button. This is instead of havingvariantprop values such asprimary,primary-inline,warning,warning-inline, etc.