Fix for DeepSpeed build error on ROCm 5.0 and above #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks okay, if the intent is to enable the conditional code only for ROCm versions < 4.4. It seems this actually corrects a bug in the implementation of PR #36. |
jithunnair-amd
approved these changes
Sep 30, 2021
Author
|
DeepSpeed build log from ROCm5.0 docker |
rraminen
added a commit
that referenced
this pull request
Jan 26, 2022
jeffra
pushed a commit
to deepspeedai/DeepSpeed
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error fatal error: 'hip/hcc_detail/hip_runtime_api.h' file not found dring the DeepSPeed build for ROCm versions 5.0 and above has been fixed
cc: @jithunnair-amd