Replace THCudaCheck with C10_CUDA_CHECK #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jithunnair-amd
changed the title
rraminen
added a commit
that referenced
this pull request
Jan 26, 2022
jeffra
pushed a commit
to deepspeedai/DeepSpeed
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue occurs as THCudaCheck is deprecated and PyTorch now considers THCDeviceUtils.cuh, THC/THC.h.
DeepSpeed still builds successfully in ROCm4.3.1 docker (rocm/pytorch:rocm4.3.1_ubuntu18.04_py3.6_pytorch_1.10.0) which has an older Pytorch versions.
Fixes https://ontrack-internal.amd.com/browse/SWDEV-314993
Reference: ROCm/apex@fec3141
cc: @jithunnair-amd