perf(amdgpu): deferred check_errno#48
Merged
yaoliu13 merged 2 commits intoamd-integrationfrom Apr 29, 2026
Merged
Conversation
Collaborator
|
I tested this locally and I can see throughput at |
rtmadduri
approved these changes
Apr 29, 2026
Collaborator
|
/run-ci |
3 similar comments
Collaborator
|
/run-ci |
Collaborator
|
/run-ci |
Collaborator
Author
|
/run-ci |
Collaborator
Author
|
/run-ci |
There was a problem hiding this comment.
Pull request overview
This PR introduces a deferred (pipelined) check_errno path for the AMDGPU + zero-copy backend to reduce sync-induced blocking while still surfacing solver errors.
Changes:
- Add a new
kernel_bit_reduction_intokernel to write reduced errno into a provided output buffer. - Implement a double-buffered, event-gated deferred errno snapshot/readback path in
RigidSolver. - Add
flush_errno()calls inSimulator.destroy()and before backward (_step_grad) to drain pending deferred snapshots; invalidate pending snapshots on state reset paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| genesis/engine/solvers/rigid/rigid_solver.py | Implements deferred errno reduction/readback, adds flush/invalidation helpers, and integrates into check_errno() + reset-like paths. |
| genesis/engine/solvers/rigid/abd/misc.py | Adds kernel_bit_reduction_into to support writing reductions into a provided buffer/slot. |
| genesis/engine/simulator.py | Flushes deferred errno snapshots during destroy and before backward to avoid missing final/forward-pass errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yaoliu13
requested changes
Apr 29, 2026
Collaborator
yaoliu13
left a comment
yaoliu13
left a comment
There was a problem hiding this comment.
Waiting for a test run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipelined Error check to prevent sync blocking!