rocAL Serialize PR 5 : Add support to serialize parameter arguments#411
Merged
kiritigowda merged 169 commits intoROCm:developfrom Dec 19, 2025
Merged
rocAL Serialize PR 5 : Add support to serialize parameter arguments#411kiritigowda merged 169 commits intoROCm:developfrom
kiritigowda merged 169 commits intoROCm:developfrom
Conversation
Remove the usage of API enums in internal node files
Add support to register all internal enums
Creates an argument instance for each arg passed in the Node Handles different argument types i.e parameters, vectors, enums and predefined types
…and ImageLoaderNode
Add support to serialize the args and pipeline details Add support to serialize the tensors.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Create single constructor with check for different data types in Argument class
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rrawther
requested changes
Dec 16, 2025
Collaborator
rrawther
left a comment
rrawther
left a comment
There was a problem hiding this comment.
please add unreleased changelog
Contributor
|
@fiona-gladwin please resolve merge conflicts |
Contributor
Author
Done file changes reduced to 4 |
LakshmiKumar23
approved these changes
Dec 17, 2025
rrawther
approved these changes
Dec 19, 2025
rrawther
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implements serialization support for parameter types in the rocAL pipeline to serialize into the protobuf format.
Technical Details
Test Plan
No new tests added, Existing tests must pass
NOTE : To be merged after PR #410