rocAL Serialize PR 6 : Add Serialization tests#412
Merged
kiritigowda merged 214 commits intoROCm:developfrom Jan 8, 2026
Merged
rocAL Serialize PR 6 : Add Serialization tests#412kiritigowda merged 214 commits intoROCm:developfrom
kiritigowda merged 214 commits intoROCm:developfrom
Conversation
Remove the usage of API enums in internal node files
Add support to register all internal enums
Creates an argument instance for each arg passed in the Node Handles different argument types i.e parameters, vectors, enums and predefined types
…and ImageLoaderNode
Add support to serialize the args and pipeline details Add support to serialize the tensors.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Create single constructor with check for different data types in Argument class
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #412 +/- ##
===========================================
+ Coverage 79.62% 80.29% +0.66%
===========================================
Files 281 281
Lines 21563 21563
===========================================
+ Hits 17169 17312 +143
+ Misses 4394 4251 -143 🚀 New features to boost your workflow:
|
rrawther
reviewed
Dec 19, 2025
rrawther
requested changes
Dec 30, 2025
Collaborator
rrawther
left a comment
rrawther
left a comment
There was a problem hiding this comment.
please address review comments
rrawther
requested changes
Jan 6, 2026
This reverts commit f821ce6.
Contributor
Author
|
@LakshmiKumar23 @rrawther Addressed all review comments |
rrawther
requested changes
Jan 8, 2026
Collaborator
rrawther
left a comment
rrawther
left a comment
There was a problem hiding this comment.
Please address the comments
Comment on lines
+198
to
+199
| compression_params.push_back(cv::IMWRITE_PNG_COMPRESSION); | ||
| compression_params.push_back(9); |
Collaborator
There was a problem hiding this comment.
This is right. I think we don't need compression parameters for OpenCV 4.0
rrawther
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds a new serialization test for the rocAL library to validate pipeline serialization functionality. The test creates a simple image processing pipeline and verifies the serialization APIs work correctly.
Technical Details
Test Plan
Test Result
NOTE : To be merged after PR #411