rocAL Serialize python support#429
Merged
kiritigowda merged 232 commits intoROCm:developfrom Jan 9, 2026
Merged
Conversation
Remove the usage of API enums in internal node files
Add support to register all internal enums
Creates an argument instance for each arg passed in the Node Handles different argument types i.e parameters, vectors, enums and predefined types
…and ImageLoaderNode
Add support to serialize the args and pipeline details Add support to serialize the tensors.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Create single constructor with check for different data types in Argument class
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rrawther
reviewed
Jan 2, 2026
rrawther
requested changes
Jan 6, 2026
Collaborator
rrawther
left a comment
rrawther
left a comment
There was a problem hiding this comment.
please address the review comments
Contributor
Author
@rrawther Addressed all review comments |
LakshmiKumar23
previously approved these changes
Jan 7, 2026
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #429 +/- ##
===========================================
+ Coverage 79.62% 80.31% +0.70%
===========================================
Files 281 281
Lines 21577 21593 +16
===========================================
+ Hits 17179 17342 +163
+ Misses 4398 4251 -147
🚀 New features to boost your workflow:
|
rrawther
previously approved these changes
Jan 8, 2026
fiona-gladwin
dismissed stale reviews from rrawther and LakshmiKumar23
via
50c4cc5
LakshmiKumar23
approved these changes
Jan 9, 2026
Contributor
@kiritigowda CI passes, can be merged |
rrawther
approved these changes
Jan 9, 2026
spolifroni-amd
approved these changes
Jan 9, 2026
kiritigowda
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds pipeline serialization functionality to the Python API.
Technical Details
Test Plan
Execute the pipeline_serialize_test.py file which should execute without any errors
NOTE:
To be merged after PR #412